Skip to content

Update dependencies and clean warning sources#133

Merged
AsafMah merged 6 commits into
mainfrom
maintenance/update-dependencies-and-warnings
Jul 12, 2026
Merged

Update dependencies and clean warning sources#133
AsafMah merged 6 commits into
mainfrom
maintenance/update-dependencies-and-warnings

Conversation

@AsafMah

@AsafMah AsafMah commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Update client dependencies covering the open Dependabot upgrades for esbuild and transitive js-yaml.
  • Add npm overrides for vulnerable/noisy transitive test tooling packages and approve the esbuild install script.
  • Update server/test NuGet package references to remove MessagePack vulnerability warnings during restore/build.
  • Make semantic-token refresh best-effort so missing VS Code command support no longer logs an unhandled rejection.
  • Fix the authentication floating-promise lint issue and a strict-null type-check issue uncovered after dependency updates.

Supersedes / Includes

Validation

  • npm ci (no deprecation/audit/allow-scripts warnings)
  • npm audit (0 vulnerabilities)
  • npm run type-check
  • npm run lint
  • npm test (499 passed)
  • npm run compile
  • npm run test:integration (46 passed)
  • dotnet build src/Server/Server.csproj (no MessagePack vulnerability warnings)
  • dotnet run --project src/ServerTests/ServerTests.csproj (200 passed)

Notes

The remaining debug-console lines seen during integration are VS Code/test-harness or other-extension noise (DEP0190, mutex/shared storage, test dialog refusal, file watcher reveal messages). The first-party vscode.executeDocumentSemanticTokensProvider unhandled rejection from the runtime debug console is removed.

Copilot AI review requested due to automatic review settings July 6, 2026 11:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the extension’s dependency stack (npm + NuGet) to address Dependabot upgrades and reduce restore/install security warnings, while also tightening a couple of runtime behaviors surfaced by newer tooling (semantic token refresh + floating promises).

Changes:

  • Updated client npm dependencies (including esbuild, js-yaml via overrides) and refreshed package-lock.json accordingly.
  • Updated server/test NuGet package references to remove/avoid vulnerability warnings during restore/build.
  • Made semantic-token refresh best-effort (avoids unhandled rejection if the VS Code command isn’t supported) and fixed a floating-promise lint issue.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/ServerTests/ServerTests.csproj Updates MSTest package version.
src/Server/Server.csproj Bumps Kusto SDK and StreamJsonRpc package versions.
src/Client/tsconfig.json Adjusts TS module output setting used for type-checking/bundler-style resolution.
src/Client/package.json Updates dependencies/devDependencies; adds npm overrides and allowScripts entry for esbuild.
src/Client/package-lock.json Lockfile refresh reflecting dependency updates and overrides.
src/Client/features/queryEditor.ts Adds clearer handling for missing history entry and makes semantic token refresh best-effort.
src/Client/features/authentication.ts Fixes a floating promise by explicitly discarding the finally() result.

Comment thread src/Client/features/queryEditor.ts Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 6, 2026 11:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Comment thread src/Client/features/queryEditor.ts Outdated
Comment thread src/Client/features/queryEditor.ts Outdated
Comment thread src/Client/package.json
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 6, 2026 11:40
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Comment thread src/Client/features/queryEditor.ts Outdated
Comment thread src/Client/features/queryEditor.ts Outdated
Copilot AI review requested due to automatic review settings July 12, 2026 09:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Comment on lines +991 to +993
const headerBytes = encoder.encode(header).length;
const startFragOffset = headerBytes + encoder.encode(`<!DOCTYPE html><html><body>${startFragment}`).length - encoder.encode(startFragment).length + encoder.encode(startFragment).length;
const fullBytes = encoder.encode(full).length;
@AsafMah AsafMah merged commit 139fd26 into main Jul 12, 2026
5 checks passed
@AsafMah AsafMah deleted the maintenance/update-dependencies-and-warnings branch July 12, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants