Avoid unused StreamJsonRpc dependencies#135
Merged
AsafMah merged 1 commit intoJul 13, 2026
Merged
Conversation
giltayar
approved these changes
Jul 13, 2026
Copilot stopped reviewing on behalf of
AsafMah due to an error
July 13, 2026 07:49
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates server/client build dependencies and build scripts to improve packaging reliability and align .NET RPC serialization dependencies.
Changes:
- Downgrade
StreamJsonRpcand add an explicitMessagePackdependency in the server project. - Add a
clean-servernpm script and run it beforedotnet publishfor debug/release builds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Server/Server.csproj | Adjusts RPC/serialization package references (StreamJsonRpc, MessagePack). |
| src/Client/package.json | Ensures the server output folder is cleaned before publishing to avoid stale artifacts. |
Comment on lines
12
to
+16
| <PackageReference Include="Microsoft.Azure.Kusto.Language" Version="12.4.0" /> | ||
| <PackageReference Include="Microsoft.VisualStudio.LanguageServer.Protocol" Version="17.2.8" /> | ||
| <PackageReference Include="Newtonsoft.Json" Version="13.0.4" /> | ||
| <PackageReference Include="StreamJsonRpc" Version="2.25.29" /> | ||
| <PackageReference Include="StreamJsonRpc" Version="2.22.23" /> | ||
| <PackageReference Include="MessagePack" Version="2.5.302" /> |
Comment on lines
+41
to
+43
| "clean-server": "node -e \"require('fs').rmSync('./server', { recursive: true, force: true })\"", | ||
| "build-release-server": "npm run clean-server && dotnet publish ../Server/Server.csproj -c Release -o ./server", | ||
| "build-debug-server": "npm run clean-server && dotnet publish ../Server/Server.csproj -c Debug -o ./server", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Kusto Explorer uses
JsonMessageFormatter, notNerdbankMessagePackFormatter. StreamJsonRpc 2.25.29 nevertheless declares Nerdbank.MessagePack and PolyType unconditionally. Both DLLs were copied into the VSIX, were unsigned, and caused the external signing pipeline's Guardian post-analysis to fail.Keeping StreamJsonRpc 2.22.23 while pinning MessagePack 2.5.302 removes those unused assemblies without restoring the MessagePack vulnerability that originally motivated the upgrade.
Validation
dotnet list src/Server/Server.csproj package --vulnerable --include-transitive— no vulnerable packagesdotnet run --project src/ServerTests/ServerTests.csproj -c Release— 200 passednpm run test:integration— 46 passednpm run package— 112-file VSIX, 24.71 MBNerdbank.MessagePack.dllandPolyType.dllare absent from the VSIXStreamJsonRpc.dlland patchedMessagePack.dllremain present