Repository navigation
FIX: do not show converter-restoration warning in empty chat - #3150
Merged
Justin Song (jsong468) merged 1 commit intoOct 13, 2026
Merged
Conversation
Justin Song (jsong468)
approved these changes
Oct 12, 2026
Justin Song (jsong468)
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the contribution!
Justin Song (jsong468)
enabled auto-merge
October 12, 2026 23:36
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3147
Description
In
frontend/src/components/Chat/ChatWindow.tsx, opening an empty Chat displayed the warning:Root Cause
recoveredDraftWarningConversationIdstarts asnull. In an empty chat or prior to opening/loading an existing conversation,viewedConversationId(activeConversationId ?? conversationId) is alsonull. The condition:sx {recoveredDraftWarningConversationId === viewedConversationId && (evaluated
null === nullastrue, causing the warning message bar to render unconditionally on fresh empty chat sessions.Solution
ChatWindow.tsxto require thatrecoveredDraftWarningConversationIdis truthy before comparing againstviewedConversationId:sx {Boolean(recoveredDraftWarningConversationId) && recoveredDraftWarningConversationId === viewedConversationId && (missingConverterSelections: truesets the destination conversation ID), while keeping empty chats and successful restorations warning-free.ChatWindow.test.tsxverifying:Tests and Documentation
frontend/src/components/Chat/ChatWindow.test.tsx.npx jest src/components/Chat/ChatWindow.test.tsx -t "converter restoration warning"(Passed)npm run type-check(0 errors)npm run lint(0 errors)