fix bare <Rule>? grammars to (<Rule>)? + quantifier RFC - #2775
Merged
Conversation
On main, postfix ? after a rule reference is a literal token, not a quantifier. Quantifiers only apply after ")". Authors across email, weather, video, code, and calendar test grammars wrote <Polite>? / <TimeSpec>? intending optional — those patterns never matched. Rewrite all bare <Name>? sites to the supported (<Name>)? form. Also add a one-pager RFC comparing: - Design A: keep group-gated quantifiers (this fix) - Design B: reserved postfix ?/*/+ (direction explored in #2765)
Design doc stays in Obsidian only; this PR is grammar-only.
Only (<Polite>)? needs grouping — authors mean optional polite prefix. Leave other >? alone: - ... <PanelRef>?) is the outer group's )? quantifier, not bare optional - trailing/mid-rule ? may be intentional literal or separate debate - calendar/display bare refs left untouched
datduyng
marked this pull request as ready for review
July 31, 2026 18:54
curtisman
approved these changes
Jul 31, 2026
Member
|
The description mention an RFC, which is not in this PR, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<Name>?sites in shipping/test.agrfiles to the supported(<Name>)?form so optional rule refs actually match.On main,
?after a rule ref is a literal token. Quantifiers only apply after). Authors wrote<Polite>?meaning optional; those patterns never matched.