Add batched version for the several API - #63904
Open
Titian Cernicova-Dragomir (dragomirtitian) wants to merge 1 commit into
Open
Add batched version for the several API#63904Titian Cernicova-Dragomir (dragomirtitian) wants to merge 1 commit into
Titian Cernicova-Dragomir (dragomirtitian) wants to merge 1 commit into
Conversation
- getDeclaredTypeOfSymbol - getAliasedSymbol - getImmediateAliasedSymbol - getExportsOfModule - getMemberInModuleExports
typescript-automation
Bot
added
the
For Uncommitted Bug
Copilot started reviewing on behalf of
Titian Cernicova-Dragomir (dragomirtitian)
August 20, 2026 10:29
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds batched checker APIs requested by #63903 to reduce IPC overhead.
Changes:
- Adds batched protocol methods and Go handlers for five checker operations.
- Adds synchronous and asynchronous TypeScript overloads.
- Adds API tests for all new batched methods.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tsc/internal/api/session.go |
Implements batched request handlers. |
tsc/internal/api/proto.go |
Defines methods and request parameters. |
packages/typescript/src/api/proto.generated.ts |
Adds generated protocol typings. |
packages/typescript/src/api/sync/api.ts |
Adds synchronous overloads. |
packages/typescript/src/api/async/api.ts |
Adds asynchronous overloads. |
packages/typescript/test/sync/api.test.ts |
Tests synchronous batching. |
packages/typescript/test/async/api.test.ts |
Tests asynchronous batching. |
Suppressed comments (1)
packages/typescript/src/api/proto.generated.ts:115
- This result type excludes
null, buthandleGetMembersInModuleExportsdeliberately leaves nil entries for missing members, producing payloads such as[null]; the new public overload also promisesundefinedfor those entries. Generate(SymbolResponse | null)[]so the protocol accurately models the server response.
getMembersInModuleExports: APIMethod<GetMembersInModuleExportsParams, SymbolResponse[]>;
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| getAliasedSymbol: APIMethod<CheckerSymbolParams, SymbolResponse>; | ||
| getAliasedSymbols: APIMethod<CheckerSymbolsParams, SymbolResponse[]>; | ||
| getImmediateAliasedSymbol: APIMethod<CheckerSymbolParams, SymbolResponse | null>; | ||
| getImmediateAliasedSymbols: APIMethod<CheckerSymbolsParams, SymbolResponse[] | null>; |
Comment on lines
+3434
to
+3436
| if len(exports) == 0 { | ||
| continue | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add batched version for the following API methods :
getDeclaredTypeOfSymbolgetAliasedSymbolgetImmediateAliasedSymbolgetExportsOfModulegetMemberInModuleExportsFixes #63903