Skip to content

Fix binder race - #63952

Open
Jake Bailey (jakebailey) wants to merge 1 commit into
microsoft:mainfrom
jakebailey:jakebailey/fix-ci-data-race
Open

Fix binder race#63952
Jake Bailey (jakebailey) wants to merge 1 commit into
microsoft:mainfrom
jakebailey:jakebailey/fix-ci-data-race

Conversation

@jakebailey

@jakebailey Jake Bailey (jakebailey) commented Aug 21, 2026

Copy link
Copy Markdown
Member

Saw this race in CI: https://github.com/microsoft/TypeScript/actions/runs/32524317879/job/96903027702

==================
WARNING: DATA RACE
Write at 0x00c038130250 by goroutine 243459:
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).setCommonJSModuleIndicator()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:932 +0x109
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bindCallExpression()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:923 +0x78
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bind()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:690 +0x95d
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bind-fm()
      <autogenerated>:1 +0x34
  github.com/microsoft/TypeScript/tsc/internal/ast.visit()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/ast/ast.go:32 +0x112
  github.com/microsoft/TypeScript/tsc/internal/ast.(*VariableDeclaration).ForEachChild()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/ast/ast_generated.go:1729 +0xd8
  github.com/microsoft/TypeScript/tsc/internal/ast.(*Node).ForEachChild()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/ast/ast_generated.go:8733 +0x2808
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bindEachChild()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:1738 +0x49
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bindVariableDeclarationFlow()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:2329 +0x31
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bindChildren()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:1711 +0x5d6
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bind()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:731 +0x141d
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bind-fm()
      <autogenerated>:1 +0x34
  github.com/microsoft/TypeScript/tsc/internal/ast.visitNodes()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/ast/ast.go:39 +0x55bc
  github.com/microsoft/TypeScript/tsc/internal/ast.visitNodeList()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/ast/ast.go:48 +0x2885
  github.com/microsoft/TypeScript/tsc/internal/ast.(*VariableDeclarationList).ForEachChild()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/ast/ast_generated.go:1774 +0x2855
  github.com/microsoft/TypeScript/tsc/internal/ast.(*Node).ForEachChild()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/ast/ast_generated.go:8735 +0x2821
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bindEachChild()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:1738 +0x68c
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bindChildren()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:1732 +0x68d
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bind()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:731 +0x141d
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bind-fm()
      <autogenerated>:1 +0x34
  github.com/microsoft/TypeScript/tsc/internal/ast.visit()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/ast/ast.go:32 +0xf7
  github.com/microsoft/TypeScript/tsc/internal/ast.(*VariableStatement).ForEachChild()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/ast/ast_generated.go:1679 +0x26
  github.com/microsoft/TypeScript/tsc/internal/ast.(*Node).ForEachChild()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/ast/ast_generated.go:8731 +0x204a
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bindEachChild()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:1738 +0x68c
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bindChildren()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:1732 +0x68d
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bind()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:731 +0x141d
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bindEachStatementFunctionsFirst()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:1767 +0x13a
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bindChildren()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:1720 +0x6dd
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bindContainer()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:1545 +0xbb4
  github.com/microsoft/TypeScript/tsc/internal/binder.(*Binder).bind()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:733 +0x1438
  github.com/microsoft/TypeScript/tsc/internal/binder.bindSourceFile.func1()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:126 +0x191
  github.com/microsoft/TypeScript/tsc/internal/binder.bindSourceFile.(*SourceFile).BindOnce.func2()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/ast/ast.go:2910 +0x33
  sync.(*Once).doSlow()
      /usr/local/vss-agent/2.336.0/_work/_tool/go-87ee608c/1.26.7/x64/src/sync/once.go:78 +0xa1
  github.com/microsoft/TypeScript/tsc/internal/binder.BindSourceFile()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/binder/binder.go:99 +0x3c
  github.com/microsoft/TypeScript/tsc/internal/compiler.(*Program).BindSourceFiles.func1()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/compiler/program.go:562 +0x168
  github.com/microsoft/TypeScript/tsc/internal/core.(*parallelWorkGroup).Queue.func1()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/core/workgroup.go:40 +0x2e

Previous read at 0x00c038130250 by goroutine 232414:
  github.com/microsoft/TypeScript/tsc/internal/ast.IsExternalOrCommonJSModule()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/ast/utilities.go:1671 +0x228
  github.com/microsoft/TypeScript/tsc/internal/compiler.(*Program).canReplaceFileInProgram()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/compiler/program.go:438 +0x1eb
  github.com/microsoft/TypeScript/tsc/internal/compiler.(*Program).ReuseProgram()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/compiler/program.go:357 +0x53a
  github.com/microsoft/TypeScript/tsc/internal/compiler.(*Program).UpdateProgram()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/compiler/program.go:302 +0x8b
  github.com/microsoft/TypeScript/tsc/internal/project.(*Project).CreateProgram()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/project.go:386 +0x1ee
  github.com/microsoft/TypeScript/tsc/internal/project.(*ProjectCollectionBuilder).updateProgram.func2.1()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/projectcollectionbuilder.go:1214 +0x6fe
  github.com/microsoft/TypeScript/tsc/internal/project/dirty.(*Box[go.shape.*uint8]).Change()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/dirty/box.go:41 +0xe9
  github.com/microsoft/TypeScript/tsc/internal/project/dirty.(*Box[*github.com/microsoft/TypeScript/tsc/internal/project.Project]).Change()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/dirty/box.go:36 +0x3a
  github.com/microsoft/TypeScript/tsc/internal/project.(*ProjectCollectionBuilder).updateProgram.func2()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/projectcollectionbuilder.go:1209 +0x12f
  github.com/microsoft/TypeScript/tsc/internal/project/dirty.(*Box[go.shape.*uint8]).Locked()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/dirty/box.go:57 +0x46
  github.com/microsoft/TypeScript/tsc/internal/project/dirty.(*Box[*github.com/microsoft/TypeScript/tsc/internal/project.Project]).Locked()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/dirty/box.go:56 +0xe
  github.com/microsoft/TypeScript/tsc/internal/project.(*ProjectCollectionBuilder).updateProgram()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/projectcollectionbuilder.go:1208 +0x655
  github.com/microsoft/TypeScript/tsc/internal/project.(*ProjectCollectionBuilder).DidRequestFile()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/projectcollectionbuilder.go:524 +0x25a
  github.com/microsoft/TypeScript/tsc/internal/project.(*Snapshot).Clone()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/snapshot.go:423 +0x1eee
  github.com/microsoft/TypeScript/tsc/internal/project.(*Session).updateSnapshot()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/session.go:1444 +0x228
  github.com/microsoft/TypeScript/tsc/internal/project.(*Session).getSnapshot()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/session.go:1105 +0x3b5
  github.com/microsoft/TypeScript/tsc/internal/project.(*Session).getSnapshotAndDefaultProject()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/session.go:1163 +0x164
  github.com/microsoft/TypeScript/tsc/internal/project.(*Session).GetLanguageService()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/session.go:1182 +0x55
  github.com/microsoft/TypeScript/tsc/internal/lsp.init.func1.registerLanguageServiceDocumentRequestHandler[go.shape.*uint8,go.shape.struct { TextEdits *[]*github.com/microsoft/TypeScript/tsc/internal/lsp/lsproto.TextEdit }].22()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/lsp/server.go:1344 +0xd8
  github.com/microsoft/TypeScript/tsc/internal/lsp.(*Server).handleRequestOrNotification()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/lsp/server.go:1145 +0x161
  github.com/microsoft/TypeScript/tsc/internal/lsp.(*Server).dispatchLoop()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/lsp/server.go:1009 +0x704
  github.com/microsoft/TypeScript/tsc/internal/lsp.(*Server).Run.func1()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/lsp/server.go:858 +0x46
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      /home/cloudtest/go/pkg/mod/golang.org/x/sync@v0.21.0/errgroup/errgroup.go:93 +0x86

Goroutine 243459 (running) created at:
  sync.(*WaitGroup).Go()
      /usr/local/vss-agent/2.336.0/_work/_tool/go-87ee608c/1.26.7/x64/src/sync/waitgroup.go:238 +0x72
  github.com/microsoft/TypeScript/tsc/internal/compiler.(*Program).BindSourceFiles()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/compiler/program.go:558 +0x2a7
  github.com/microsoft/TypeScript/tsc/internal/project.(*Project).CreateProgram()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/project.go:440 +0xa57
  github.com/microsoft/TypeScript/tsc/internal/project.(*ProjectCollectionBuilder).updateProgram.func2.1()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/projectcollectionbuilder.go:1214 +0x6fe
  github.com/microsoft/TypeScript/tsc/internal/project/dirty.(*Box[go.shape.*uint8]).Change()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/dirty/box.go:41 +0xe9
  github.com/microsoft/TypeScript/tsc/internal/project/dirty.(*Box[*github.com/microsoft/TypeScript/tsc/internal/project.Project]).Change()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/dirty/box.go:36 +0x3a
  github.com/microsoft/TypeScript/tsc/internal/project.(*ProjectCollectionBuilder).updateProgram.func2()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/projectcollectionbuilder.go:1209 +0x12f
  github.com/microsoft/TypeScript/tsc/internal/project/dirty.(*Box[go.shape.*uint8]).Locked()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/dirty/box.go:57 +0x46
  github.com/microsoft/TypeScript/tsc/internal/project/dirty.(*Box[*github.com/microsoft/TypeScript/tsc/internal/project.Project]).Locked()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/dirty/box.go:56 +0xe
  github.com/microsoft/TypeScript/tsc/internal/project.(*ProjectCollectionBuilder).updateProgram()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/projectcollectionbuilder.go:1208 +0x655
  github.com/microsoft/TypeScript/tsc/internal/project.(*ProjectCollectionBuilder).DidRequestFile()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/projectcollectionbuilder.go:524 +0x25a
  github.com/microsoft/TypeScript/tsc/internal/project.(*Snapshot).Clone()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/snapshot.go:423 +0x1eee
  github.com/microsoft/TypeScript/tsc/internal/project.(*Session).updateSnapshot()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/session.go:1444 +0x228
  github.com/microsoft/TypeScript/tsc/internal/project.(*Session).getSnapshot()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/session.go:1105 +0x3b5
  github.com/microsoft/TypeScript/tsc/internal/project.(*Session).getSnapshotAndDefaultProject()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/session.go:1163 +0x164
  github.com/microsoft/TypeScript/tsc/internal/project.(*Session).GetLanguageService()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/project/session.go:1182 +0x55
  github.com/microsoft/TypeScript/tsc/internal/lsp.init.func1.registerLanguageServiceDocumentRequestHandler[go.shape.*uint8,go.shape.struct { TextEdits *[]*github.com/microsoft/TypeScript/tsc/internal/lsp/lsproto.TextEdit }].22()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/lsp/server.go:1344 +0xd8
  github.com/microsoft/TypeScript/tsc/internal/lsp.(*Server).handleRequestOrNotification()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/lsp/server.go:1145 +0x161
  github.com/microsoft/TypeScript/tsc/internal/lsp.(*Server).dispatchLoop()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/lsp/server.go:1009 +0x704
  github.com/microsoft/TypeScript/tsc/internal/lsp.(*Server).Run.func1()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/lsp/server.go:858 +0x46
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      /home/cloudtest/go/pkg/mod/golang.org/x/sync@v0.21.0/errgroup/errgroup.go:93 +0x86

Goroutine 232414 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      /home/cloudtest/go/pkg/mod/golang.org/x/sync@v0.21.0/errgroup/errgroup.go:78 +0x11c
  github.com/microsoft/TypeScript/tsc/internal/lsp.(*Server).Run()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/lsp/server.go:858 +0x1e5
  github.com/microsoft/TypeScript/tsc/internal/testutil/lsptestutil.NewLSPClient.func1()
      /usr/local/vss-agent/2.336.0/_work/TypeScript/TypeScript/tsc/internal/testutil/lsptestutil/lspclient.go:112 +0x78
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      /home/cloudtest/go/pkg/mod/golang.org/x/sync@v0.21.0/errgroup/errgroup.go:93 +0x86
==================

A "fix" is to just ensure everything's bound, since the LS et al is surely going to need that info.

Copilot AI balanced review requested due to automatic review settings August 21, 2026 21:53
@github-project-automation github-project-automation Bot moved this to Not started in PR Backlog Aug 21, 2026
@typescript-automation typescript-automation Bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 21, 2026
Copilot AI reviewed Aug 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures cached source files are fully bound before concurrent consumers can access them, preventing binder data races.

Changes:

  • Bind ordinary and content-mapped source files before cache publication.
  • Add regression coverage for pre-publication binding.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tsc/internal/project/parsecache.go Binds parsed files before caching.
tsc/internal/project/compilerhost.go Binds canonical and supplemental mapped files.
tsc/internal/project/refcountcache_test.go Verifies cached CommonJS files are already bound.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@andrewbranch Andrew Branch (andrewbranch) Awaiting requested review from andrewbranch

At least 1 approving review is required to merge this pull request.

Assignees

@jakebailey Jake Bailey (jakebailey)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Status: Not started

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakebailey