feat(installer): add nvme-cli to ISO and target - #18805
Open
Christopher Co (christopherco) wants to merge 1 commit into
Open
feat(installer): add nvme-cli to ISO and target#18805Christopher Co (christopherco) wants to merge 1 commit into
Christopher Co (christopherco) wants to merge 1 commit into
Conversation
Provide NVMe device management before and after installation. Include nvme-cli in the live image and target package list, which also populates the offline repository and both normal and encrypted kickstarts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: abfc8b13-2e14-4528-978e-97fbc5c45939
Copilot started reviewing on behalf of
Christopher Co (christopherco)
September 12, 2026 16:30
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Adds nvme-cli to the installer ISO and installed target system for NVMe management.
Changes:
- Includes
nvme-cliin the live ISO. - Adds it to target packages, offline repository, and generated kickstarts.
File summaries
| File | Description |
|---|---|
base/images/vm-iso-installer/vm-iso-installer.kiwi |
Includes nvme-cli in the live ISO. |
base/images/vm-iso-installer/config.sh |
Adds nvme-cli to target installation packages and kickstarts. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Author
|
/azp run |
Christopher Co (christopherco)
marked this pull request as ready for review
September 12, 2026 16:36
Christopher Co (christopherco)
requested a review
from a team
as a code owner
September 12, 2026 16:36
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide NVMe device management before and after installation. Include nvme-cli in the live image and target package list, which also populates the offline repository and both normal and encrypted kickstarts.
Fixes: AB#23494