Skip to content

chore: Update tags to avoid SFI W18 fix violation#581

Open
NirajC-Microsoft wants to merge 2 commits intodevfrom
psl-sfiw18
Open

chore: Update tags to avoid SFI W18 fix violation#581
NirajC-Microsoft wants to merge 2 commits intodevfrom
psl-sfiw18

Conversation

@NirajC-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

This pull request updates the infrastructure templates to enhance resource tagging and update Bicep tooling versions. The main improvements are the addition of more descriptive tags to deployed resources and an upgrade of the Bicep template generator, which affects the generated ARM templates.

Tagging improvements:

  • Added new tags (TemplateName, Type, CreatedBy, and DeploymentName) to the avmContainerAppEnv module in both infra/main.bicep and infra/main_custom.bicep to improve resource identification and traceability. [1] [2]
  • Updated the tags assignment logic in infra/main.json to include the new tags using a merged object expression.

Bicep tooling and template updates:

  • Upgraded the Bicep template generator version from 0.42.1.51946 to 0.43.8.12551 throughout infra/main.json, resulting in updated template hashes and metadata. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

Minor fixes and ordering:

  • Fixed the ordering of DNS zone resource references in infra/main.json for consistency.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants