Repository navigation
Fix typos - #146
Merged
Merged
Fix typos#146
Conversation
Leonard Hecker (lhecker)
requested changes
Jul 21, 2026
|
|
||
| winner = (not_empty ? run : END_OF_RUN); | ||
|
|
||
| /* start at the bottom of the tournament tree, work up the the top |
There was a problem hiding this comment.
We don't accept changes for dependencies. The other two changes are good, however.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review! I've dropped the deps/ntsort/sort.c change and
force-pushed — the PR now contains only the two buffer.rs typo fixes.
Matteo Baccan (matteobaccan)
force-pushed
the
fix
branch
from
August 24, 2026 21:59
f002196 to
f380585
Compare
Leonard Hecker (lhecker)
approved these changes
Aug 25, 2026
Leonard Hecker (lhecker)
left a comment
Leonard Hecker (lhecker)
left a comment
Member
There was a problem hiding this comment.
I'm generally opposed to merge trivial changes. So, in the future: Bigger PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have fixes some typos errors: correct typos in comments in buffer.rs and sort.c