Preserve late events after continue-as-new#711
Merged
berndverst merged 2 commits intomainfrom Apr 23, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the worker shim’s TaskOrchestrationContextWrapper to ensure late-arriving external events are forwarded to the next execution after ContinueAsNew has been scheduled with PreserveUnprocessedEvents enabled, and adds a focused regression test for that behavior.
Changes:
- Track whether
ContinueAsNew(...PreserveUnprocessedEvents=true)has been scheduled, and forward late external events viaSendEventinstead of buffering them on the soon-to-be-discarded wrapper. - Refactor buffered-event forwarding into a helper method reused by both “drain buffer” and “late event” paths.
- Add a wrapper test that simulates a late external event after
ContinueAsNewand validates an event is sent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Worker/Core/Shims/TaskOrchestrationContextWrapper.cs | Adds state + forwarding logic so late external events are sent to the next execution after ContinueAsNew with preservation enabled. |
| test/Worker/Core.Tests/Shims/TaskOrchestrationContextWrapperTests.cs | Adds a test exercising the late-event forwarding behavior using a tracking inner context and reflection to invoke CompleteExternalEvent. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sophiatev
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
After ContinueAsNew is scheduled with event preservation enabled, late external events should be forwarded to the next execution instead of being buffered on the current wrapper instance that is about to be discarded.
Validation