Preserve scroll position when switching documents - #976
Open
Johan Andersson (johandersson) wants to merge 1 commit into
Open
Johan Andersson (johandersson) wants to merge 1 commit into
Johan Andersson (johandersson) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
Johan Andersson (johandersson)
force-pushed
the
fix/586-document-scroll-position
branch
from
October 4, 2026 09:29
1768d7a to
7849408
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep textarea viewport state per text buffer so switching documents neither transfers the active document's scroll offset nor loses each document's previous position. Stale viewport entries use weak references and are removed after their buffers are closed.
Adds a regression test covering independent scroll positions across repeated document switches.
Fixes #586
Testing:
cargo test -p edit --libcargo clippy -p edit --lib --tests -- -D warningsrustfmt --edition 2024 --check --config newline_style=Native crates/edit/src/tui.rs