chore(lint): migrate repo to oxlint and stabilize validation#4075
Open
Saadnajmi wants to merge 7 commits intomicrosoft:mainfrom
Open
chore(lint): migrate repo to oxlint and stabilize validation#4075Saadnajmi wants to merge 7 commits intomicrosoft:mainfrom
Saadnajmi wants to merge 7 commits intomicrosoft:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 9fad281 The changes in this PR will be included in the next version bump. This PR includes changesets to release 74 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Saadnajmi
force-pushed
the
chore/oxlint-migration-review
branch
from
ba05514 to
7ce82c8
Compare
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
Saadnajmi
force-pushed
the
chore/oxlint-migration-review
branch
from
a89f2a3 to
9c3eaf4
Compare
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
The TS build failed because private.ts imports from @rnx-kit/oxlint-config/* which ships no type declarations. Add a triple-slash reference so the existing types.d.ts is always in scope, even when other packages compile this file with their own tsconfig. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Saadnajmi
force-pushed
the
chore/oxlint-migration-review
branch
5 times, most recently
from
b0aac5e to
b382af0
Compare
Two CI fixes: 1. types.d.ts: Use OxlintConfig type instead of unknown for the @rnx-kit/oxlint-config ambient module declarations, since the extends field in defineConfig expects OxlintConfig[]. 2. depcheck.ts: Fix injectedDevDeps() to read Object.keys from the nested .dependencies object rather than the wrapper, so dynamically injected deps like oxlint are properly ignored. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Saadnajmi
force-pushed
the
chore/oxlint-migration-review
branch
from
b382af0 to
0413432
Compare
Saadnajmi
commented
Apr 16, 2026
| userCallback && userCallback(!isChecked); | ||
| setChecked(!isChecked); | ||
| }, [isChecked, setChecked]); | ||
| }, [isChecked, setChecked, userCallback]); |
Collaborator
Author
There was a problem hiding this comment.
Note, changes like this (And in useAsPressable) could change behavior
Saadnajmi
commented
Apr 16, 2026
Comment on lines
26
to
32
| setHoverState({ hovered: true }); | ||
| if (props.onHoverIn) { | ||
| props.onHoverIn(e); | ||
| if (onHoverInProp) { | ||
| onHoverInProp(e); | ||
| } | ||
| }, | ||
| [setHoverState, props.onHoverIn], | ||
| [onHoverInProp, setHoverState], | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
Better code but could change behavior
Saadnajmi
commented
Apr 16, 2026
Comment on lines
69
to
74
| const slotProps = {}; | ||
| Object.keys(styles).forEach((key) => { | ||
| for (const key of Object.keys(styles)) { | ||
| const style = styles[key]; | ||
| slotProps[key] = typeof style === 'function' ? style(tokens, theme, cache(null, [key])[1]) : style; | ||
| }); | ||
| } | ||
| return slotProps as TSlotProps; |
Saadnajmi
commented
Apr 16, 2026
Comment on lines
-132
to
+134
| Object.keys(slotProps).forEach((key) => { | ||
| for (const key of Object.keys(slotProps)) { | ||
| expect(slotProps[key]).toBe(slotProps2[key]); | ||
| }); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
same change here
Saadnajmi
commented
Apr 16, 2026
Comment on lines
59
to
61
| }), | ||
| [component, filter, slotData], | ||
| [filter, slotData], | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
maybe behavioral change
Saadnajmi
commented
Apr 16, 2026
Comment on lines
41
to
43
| const hideOpacity = status === 'inactive' && hidesWhenStopped == true ? 0 : 1; | ||
| const rotationAngle = new Animated.Value(0); | ||
| const rotationAngle = useRef(new Animated.Value(0)).current; | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Probably want to check this
Saadnajmi
commented
Apr 16, 2026
Comment on lines
61
to
67
| ).start(); | ||
| }, [memoizedShimmerData.delay, memoizedShimmerData.duration]); | ||
| }, [endValue, memoizedShimmerData.delay, memoizedShimmerData.duration, x1]); | ||
|
|
||
| useEffect(() => { | ||
| shimmerAnimation(); | ||
| }); | ||
| }, [shimmerAnimation]); | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Probably check this
Saadnajmi
commented
Apr 16, 2026
Comment on lines
65
to
76
| // This effect should only run when the size of the item or container changes. | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps -- intentionally only re-run when size or containerSize changes | ||
| }, [size, containerSize]); | ||
|
|
||
| const onLayout = React.useCallback( | ||
| (e: LayoutChangeEvent) => { | ||
| const itemSize = { width: e.nativeEvent.layout.width, height: e.nativeEvent.layout.height }; | ||
| setSize(itemSize); | ||
| props.onLayout && props.onLayout(e); | ||
| onLayoutProp && onLayoutProp(e); | ||
| }, | ||
| [props], | ||
| [onLayoutProp], | ||
| ); // Get item dimensions |
Saadnajmi
commented
Apr 16, 2026
Comment on lines
+7
to
+8
| '@rnx-kit/no-export-all': 'off', | ||
| 'typescript/class-literal-property-style': 'off', |
Collaborator
Author
There was a problem hiding this comment.
These two seem added
Saadnajmi
commented
Apr 16, 2026
| bail: 1, // If you only want to run your tests until a specific amount of tests have failed use bail (default is 0 - don't bail, run all tests). | ||
| waitforTimeout: defaultWaitForTimeout, // Default timeout for all waitForXXX commands. | ||
| connectionRetryTimeout: defaultConnectionRetryTimeout, // Timeout for any WebDriver request to a driver or grid. | ||
| connectionRetryCount: 2, // Maximum count of request retries to the Selenium server. |
Collaborator
Author
There was a problem hiding this comment.
Why remove this?
Saadnajmi
commented
Apr 16, 2026
| "build-cjs": "tsgo --outDir lib-commonjs", | ||
| "build-core": "tsgo --outDir lib --module esnext --moduleResolution bundler", | ||
| "bundle": "rnx-cli bundle --dev false", | ||
| "bundle": "yarn bundle:android && yarn bundle:ios && yarn bundle:macos", |
Collaborator
Author
There was a problem hiding this comment.
Why this change?
Saadnajmi
commented
Apr 16, 2026
Comment on lines
+6
to
+11
| rules: { | ||
| '@rnx-kit/no-export-all': 'off', | ||
| '@rnx-kit/no-foreach-with-captured-variables': 'off', | ||
| 'react-hooks/exhaustive-deps': 'off', | ||
| 'typescript/array-type': 'off', | ||
| }, |
Collaborator
Author
There was a problem hiding this comment.
Do we need to add these? Can they be in the base?
Saadnajmi
commented
Apr 16, 2026
| } | ||
| }, | ||
| [checkedValue, showCloseIcon, closeIconOnPress], | ||
| [closeIconOnPress, closeIconVisibile], |
Collaborator
Author
There was a problem hiding this comment.
Could be a change
Saadnajmi
commented
Apr 16, 2026
Comment on lines
59
to
+62
| const dismissCallback = React.useCallback(() => { | ||
| userProps.onDismiss(); | ||
| onDismiss(); | ||
| setShowMenu?.(false); | ||
| }, [setShowMenu, userProps.onDismiss]); | ||
| }, [onDismiss, setShowMenu]); |
Collaborator
Author
There was a problem hiding this comment.
Could be a change
Saadnajmi
commented
Apr 16, 2026
Comment on lines
-162
to
164
| const transforms = []; | ||
| const transforms = useMemo(() => { | ||
| const nextTransforms = []; | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Lot of changes here
Saadnajmi
commented
Apr 16, 2026
Comment on lines
32
to
+38
| React.useEffect(() => { | ||
| listContext.addRadioItem(name); | ||
| addRadioItem(name); | ||
|
|
||
| return () => { | ||
| listContext.removeRadioItem(name); | ||
| removeRadioItem(name); | ||
| }; | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps -- intentionally run only on mount/unmount |
Saadnajmi
commented
Apr 16, 2026
Comment on lines
-37
to
+43
| const doNotTakePointerCapture = props.doNotTakePointerCapture ?? openOnHover; | ||
| const doNotTakePointerCapture = doNotTakePointerCaptureProp ?? openOnHover; |
Saadnajmi
commented
Apr 16, 2026
| } | ||
| }, | ||
| [...refs], | ||
| [refs], |
Saadnajmi
commented
Apr 16, 2026
Comment on lines
-80
to
81
| menuItems.forEach((item) => { | ||
| for (const item of menuItems) { | ||
| const imageSource = extractResolvedImageSourceFromIcon(item.icon); |
Saadnajmi
commented
Apr 16, 2026
Comment on lines
-27
to
+34
| const onPressRerouted = () => { | ||
| const onPressRerouted = React.useCallback(() => { | ||
| // Prevent calls to RadioGroup's onChange on the currently selected button | ||
| if (buttonKey != info.selectedKey) { | ||
| info.onChange && info.onChange(buttonKey); | ||
| info.updateSelectedButtonRef && componentRef && info.updateSelectedButtonRef(componentRef); | ||
| if (buttonKey != selectedKey) { | ||
| onChange && onChange(buttonKey); | ||
| updateSelectedButtonRef && componentRef && updateSelectedButtonRef(componentRef); | ||
| } | ||
| }; | ||
| }, [buttonKey, componentRef, onChange, selectedKey, updateSelectedButtonRef]); |
Collaborator
Author
There was a problem hiding this comment.
A lot of changes here
Saadnajmi
commented
Apr 16, 2026
Comment on lines
-45
to
50
| const changeSelection = () => { | ||
| if (buttonKey != info.selectedKey) { | ||
| info.onChange && info.onChange(buttonKey); | ||
| info.updateSelectedButtonRef && componentRef && info.updateSelectedButtonRef(componentRef); | ||
| const changeSelection = React.useCallback(() => { | ||
| if (buttonKey != selectedKey) { | ||
| onChange && onChange(buttonKey); | ||
| updateSelectedButtonRef && componentRef && updateSelectedButtonRef(componentRef); | ||
| } |
Saadnajmi
commented
Apr 16, 2026
Comment on lines
-67
to
68
| buttonKeys.push(buttonKey); | ||
| setButtonKeys(buttonKeys); | ||
| setButtonKeys((prevButtonKeys) => [...prevButtonKeys, buttonKey]); | ||
| }, |
Saadnajmi
commented
Apr 16, 2026
Comment on lines
124
to
126
| }, | ||
| [radioGroupContext], | ||
| [enabledValues, isRTL, onChange, selectedValue, updateInvoked], | ||
| ); |
Saadnajmi
commented
Apr 16, 2026
Comment on lines
+13
to
+19
| ".": { | ||
| "default": "./private.ts" | ||
| }, | ||
| "./private": { | ||
| "default": "./private.ts" | ||
| }, | ||
| "./package.json": "./package.json" |
Saadnajmi
commented
Apr 16, 2026
| const resolvedSlotProps = { tokens: tokenPropInfo.tokens || {} }; | ||
|
|
||
| Object.getOwnPropertyNames(handlers).forEach((slotName) => { | ||
| for (const slotName of Object.getOwnPropertyNames(handlers)) { |
Saadnajmi
commented
Apr 16, 2026
| }); | ||
| } | ||
| }, [rotationAngle, animating]); | ||
| }, [rotationAngle]); |
Saadnajmi
commented
Apr 16, 2026
| stopRotation(); | ||
| } | ||
| }, [animating, hidesWhenStopped, rotationAngle]); | ||
| }, [animating, rotationAngle, startRotation]); |
Saadnajmi
commented
Apr 16, 2026
Comment on lines
-52
to
+63
| [props?.onScrimClick], | ||
| [onScrimClickProp], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the repo ESLint-based lint workflow with oxlint, fixes the violations surfaced by that migration, and closes the validation issue that was still breaking the full Lage run.
What changed
1. Migrate the repo from ESLint to oxlint
2. Fix oxlint violations across the repo
3. Stabilize full repo validation
Why this is split this way
The commit history is organized to make review easier:
This lets the tooling migration, rule-compliance changes, and validation fix be reviewed independently.
Validation