Skip to content

service: add unit tests for LCOW v2 shim service layer #2649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shreyanshjain7174 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

service: add unit tests for LCOW v2 shim service layer #2649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
353 changes: 353 additions & 0 deletions cmd/containerd-shim-lcow-v2/service/mocks/mock_service.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions cmd/containerd-shim-lcow-v2/service/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,9 @@ type Service struct {
// For LCOW shim, sandboxID corresponds 1-1 with the UtilityVM managed by the shim.
sandboxID string

// vmController is responsible for managing the lifecycle of the underlying utility VM and its associated resources.
vmController *vm.Controller
// vmController is responsible for managing the lifecycle of the underlying
// utility VM. Tests substitute a mock; production passes [*vm.Controller].
Copy link
Copy Markdown
Contributor

@rawahars rawahars Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Please remove this statement Tests substitute a mock; production passes [*vm.Controller].

vmController vmController

// podControllers maps podID -> PodController for each active pod.
podControllers map[string]*pod.Controller
Copy link
Copy Markdown
Contributor

@rawahars rawahars Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we create similar interface for pod.Controller too?

Expand Down
Loading
Loading