[shimV2] Remove vpmem controller and related config from V2 shim code paths#2703
Merged
rawahars merged 3 commits intomicrosoft:mainfrom Apr 23, 2026
Merged
[shimV2] Remove vpmem controller and related config from V2 shim code paths#2703rawahars merged 3 commits intomicrosoft:mainfrom
rawahars merged 3 commits intomicrosoft:mainfrom
Conversation
The v2 LCOW shim does not support vPMem devices. Reject any request that asks for a non-zero vPMem count and stop emitting a VirtualPMemController in the compute system document. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
rawahars
force-pushed
the
remove_vpmem_v2
branch
from
9254770 to
058673a
Compare
jterry75
approved these changes
Apr 23, 2026
…ration Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
rawahars
force-pushed
the
remove_vpmem_v2
branch
from
058673a to
ffbc126
Compare
jterry75
approved these changes
Apr 23, 2026
rawahars
added this to the
[shim V2] Adds the V2 shim for Linux containers on Windows milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request removes all support for configuring VPMem (Virtual Persistent Memory) devices in v2 LCOW (Linux Containers on Windows) shims. VPMem-related options are now explicitly rejected, and the codebase and tests are updated accordingly to reflect that v2 shims do not support VPMem devices. The changes simplify device configuration logic and clarify the expected behavior for confidential and non-confidential scenarios.
Key changes include:
Removal of VPMem support in device configuration:
The
parseDeviceOptionsfunction indevices.gono longer configures or returns a VPMem controller; any attempt to enable VPMem now returns an error stating that v2 shims do not support VPMem devices. Default VPMem count is set to 0, and VPMem-related parameters and logic are removed.The
BuildSandboxConfigfunction and related code paths are updated to remove references to VPMem controllers and to stop passing or using VPMem-related arguments.Test suite updates:
specs_test.gothat previously expected VPMem to be configured or validated VPMem-specific behavior are rewritten or removed. New tests assert that attempts to configure VPMem result in errors, and that VPMem is always unset in the resulting VM config.Documentation and comments:
Kernel argument construction:
tests accurately reflect this unsupported scenario.