Fix charset detection returning literal None string on empty input - #2406
Closed
SpongeBob (As9xm) wants to merge 1 commit into
Closed
Fix charset detection returning literal None string on empty input#2406SpongeBob (As9xm) wants to merge 1 commit into
SpongeBob (As9xm) wants to merge 1 commit into
Conversation
Member
|
I believe this was addressed in #2384. Please re-open, if I am mistaken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlainTextConverterandCsvConverterdidstr(from_bytes(...).best())without a None check, so when detection failed it returned the literal string"None"as document content.This change checks for
Noneand falls back to""to avoid corrupting output.