Skip unused Bazel install in benchmark Docker image - #872
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job benchmark
Skip unused Bazel install in benchmark Docker image
Aug 13, 2026
Member
|
Copilot Would it be better to migrate to the latest mimalloc-bench. I have fixed a bunch of issues there recently. |
Contributor
Author
Good idea. Bumped the pin to |
Co-authored-by: mjp41 <270363+mjp41@users.noreply.github.com>
…PLAN.md Co-authored-by: mjp41 <270363+mjp41@users.noreply.github.com>
…hing it Co-authored-by: mjp41 <270363+mjp41@users.noreply.github.com>
Matthew Parkinson (mjp41)
force-pushed
the
copilot/fix-benchmark-job
branch
from
September 3, 2026 08:59
9cb26d7 to
b3748b7
Compare
Matthew Parkinson (mjp41)
marked this pull request as ready for review
September 3, 2026 09:00
Matthew Parkinson (mjp41)
approved these changes
Sep 3, 2026
Coverage report (cross-platform merged)Lines covered ( Merged line coverage is the per-line union across all platforms. Region coverage is reported per-platform only; no cross-platform region total is computed. Per-directory breakdown
Per-platform contributions (advisory)
|
Matthew Parkinson (mjp41)
enabled auto-merge (squash)
September 3, 2026 10:55
Matthew Parkinson (mjp41)
disabled auto-merge
September 3, 2026 10:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark GitHub Actions job fails while building
benchmark/Dockerfilebecause the pinnedmimalloc-benchsetup script downloads a Bazel GPG key from a URL that now returns 404.Benchmark image setup
mimalloc-benchscript during the Docker build.aptinstallbazelcall before running./build-bench-env.sh packages.mimalloc-benchrevision unchanged.Scope of change
tcgbenchmark path.