Skip to content

Skip unused Bazel install in benchmark Docker image - #872

Merged
Matthew Parkinson (mjp41) merged 3 commits into
mainfrom
copilot/fix-benchmark-job
Sep 3, 2026
Merged

Skip unused Bazel install in benchmark Docker image#872
Matthew Parkinson (mjp41) merged 3 commits into
mainfrom
copilot/fix-benchmark-job

Conversation

Copilot AI commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

The benchmark GitHub Actions job fails while building benchmark/Dockerfile because the pinned mimalloc-bench setup script downloads a Bazel GPG key from a URL that now returns 404.

  • Benchmark image setup

    • Patches the pinned mimalloc-bench script during the Docker build.
    • Removes the standalone aptinstallbazel call before running ./build-bench-env.sh packages.
    • Keeps the pinned mimalloc-bench revision unchanged.
  • Scope of change

    • Bazel is only needed for the tcg benchmark path.
    • This Dockerfile builds and runs the configured benchmark workloads against snmalloc only, so the Bazel install is unused in this job.
RUN sed -i '/^[[:space:]]*aptinstallbazel[[:space:]]*$/d' build-bench-env.sh && \
    if grep -q '^[[:space:]]*aptinstallbazel[[:space:]]*$' build-bench-env.sh; then \
      echo "failed to remove unused Bazel install"; \
      exit 1; \
    fi

@mjp41

Copy link
Copy Markdown
Member

Copilot Would it be better to migrate to the latest mimalloc-bench. I have fixed a bunch of issues there recently.

Copilot AI commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Copilot Would it be better to migrate to the latest mimalloc-bench. I have fixed a bunch of issues there recently.

Good idea. Bumped the pin to fcb165f (includes your Bazel apt-key fix and other recent CI fixes, green on upstream CI) and dropped the sed patch in 6f4c8d2. Also updated the hardcoded rocksdb-8.1.1 path to rocksdb-10.10.1 since that version bumped too.

Copilot AI and others added 3 commits September 3, 2026 09:59
Co-authored-by: mjp41 <270363+mjp41@users.noreply.github.com>
…PLAN.md

Co-authored-by: mjp41 <270363+mjp41@users.noreply.github.com>
…hing it

Co-authored-by: mjp41 <270363+mjp41@users.noreply.github.com>
@mjp41
Matthew Parkinson (mjp41) marked this pull request as ready for review September 3, 2026 09:00
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Coverage report (cross-platform merged)

Lines covered (src/snmalloc/**): 2820 / 3180 (88.68%)

Merged line coverage is the per-line union across all platforms. Region coverage is reported per-platform only; no cross-platform region total is computed.

Per-directory breakdown

Directory Lines covered Lines executable %
src/snmalloc/stl 2 4 50.00%
src/snmalloc/override 94 156 60.26%
src/snmalloc/pal 343 449 76.39%
src/snmalloc/mitigations 14 18 77.78%
src/snmalloc/aal 52 60 86.67%
src/snmalloc/ds_core 349 399 87.47%
src/snmalloc/global 266 303 87.79%
src/snmalloc/ds 328 357 91.88%
src/snmalloc/backend_helpers 336 356 94.38%
src/snmalloc/mem 838 873 95.99%
src/snmalloc/ds_aal 108 112 96.43%
src/snmalloc/backend 90 93 96.77%
Per-platform contributions (advisory)
Platform Lines covered Lines executable Lines % Regions covered Regions executable Regions %
freebsd-14 4273 4726 90.41% 3858 5677 67.96%
linux-self-host-shim-checks 4432 4888 90.67% 4075 6136 66.41%
linux-self-host-shim-checks-selfhost 1640 2323 70.60% 1500 2913 51.49%
macos-14 4249 4693 90.54% 3880 5691 68.18%
windows-2022 4172 4713 88.52% 3827 5653 67.70%

@mjp41
Matthew Parkinson (mjp41) merged commit b7fd8a3 into main Sep 3, 2026
198 checks passed
@mjp41
Matthew Parkinson (mjp41) deleted the copilot/fix-benchmark-job branch September 3, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants