[Bug]: Java response schema JavaDoc marks read-required properties on JSON Merge Patch models as optional #12449

Describe the bug

For a model used in JSON Merge Patch (application/merge-patch+json), a required property with @visibility(Lifecycle.Read, Lifecycle.Update) represents a field initialized by the service on creation and always returned in responses, while remaining optional in PATCH requests and omitted in Create requests.

After microsoft/typespec#12378 (released in @azure-tools/typespec-java 0.48.4, following up on Azure/typespec-azure#5721), ModelPropertyMapper sets both required = false and requiredForCreate = false on such properties so model setter JavaDoc no longer falsely claims "Required when create the resource."

However, ClientMethodTemplateBase.responseBodySchemaJavadoc renders Response Body Schema JavaDoc using those same request-oriented flags (property.isRequired() and property.isRequiredForCreate()):

• ModelPropertyMapper.java#L67-L70
• ClientMethodTemplateBase.java#L273-L305 and #L393-L403

As a result, Response Body Schema JavaDoc documents a read-required property as (Optional) (and documents create-required properties on the same response model as (Optional, Required on create) instead of (Required)).

Expected in Response Body Schema:

state: String (Required)

Actual in Response Body Schema:

state: String (Optional)

Reproduction

This is already reproduced in the test fixture added by microsoft/typespec#12378:

1. In patch.tsp#L26-L27, Resource.state is defined as required (no ?) with @visibility(Lifecycle.Read, Lifecycle.Update):

   model Resource {
     @visibility(Lifecycle.Read)
     id: string;
   
     @visibility(Lifecycle.Create)
     name: string;
   
     description?: string;
   
     @visibility(Lifecycle.Read, Lifecycle.Update)
     state: string;
   
     map: Record<InnerModel>;
   }

2. In the generated PatchClient.java#L77-L90, the Response Body Schema JavaDoc marks state as (Optional) and map as (Optional, Required on create):

    * <p><strong>Response Body Schema</strong></p>
    * 
    * <pre>
    * {@code
    * {
    *     id: String (Required)
    *     name: String (Required)
    *     description: String (Optional)
    *     state: String (Optional)
    *     map (Optional, Required on create): {
    *         String (Required): {
    *             name: String (Optional, Required on create)
    *             description: String (Optional)
    *         }
    *     }
    * }
    * }
    * </pre>
   

Checklist

• Follow our Code of Conduct
• Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion.
• The provided reproduction is a minimal reproducible example of the bug.