Always enable diff highlighting in playground output viewer#10468
Merged
JoshLove-msft merged 2 commits intomainfrom Apr 23, 2026
Merged
Always enable diff highlighting in playground output viewer#10468JoshLove-msft merged 2 commits intomainfrom
JoshLove-msft merged 2 commits intomainfrom
Conversation
Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/286bd494-4a2a-416d-83c2-5a46a8c00c23 Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove diff highlighting config for all emitters
Always enable diff highlighting in playground output viewer
Apr 23, 2026
timotheeguerin
approved these changes
Apr 23, 2026
commit: |
Collaborator
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
newChangeDiffemitter option was meant to be opt-in for the C#/Python emitters, but a default oftruemade it always-on. Per the issue, the feature is generally useful — remove the config and make it unconditional.Changes
packages/playground: dropped thenewChangeDifffield fromPlaygroundEmitterOptionsand thehighlightChangesprop plumbing throughOutputView→createFileViewer→FileViewerComponent→useFileChanges. Changed-file/line tracking now always runs.website/src/components/playground-component/playground.tsx: removed thenewChangeDiff: trueoverrides on the python/csharp emitter entries.breakingentry for@typespec/playground(option removed from the public API).Before / after
export interface PlaygroundEmitterOptions { debounce?: number; - /** When true, highlights changed files and lines after recompilation. */ - newChangeDiff?: boolean; }emitterOptions={{ - "@typespec/http-client-python": { debounce: 500, newChangeDiff: true }, - "@typespec/http-client-csharp": { debounce: 500, newChangeDiff: true }, + "@typespec/http-client-python": { debounce: 500 }, + "@typespec/http-client-csharp": { debounce: 500 }, }}