Enable verbatimModuleSyntax in tsconfig.base.json [skip chg] - #11521
Draft
timotheeguerin wants to merge 2 commits into
Draft
Enable verbatimModuleSyntax in tsconfig.base.json [skip chg]#11521timotheeguerin wants to merge 2 commits into
timotheeguerin wants to merge 2 commits into
Conversation
Add verbatimModuleSyntax to the emitter tsconfig and convert type-only imports/exports to import type / export type.
All workspace packages and the standalone emitters have been converted to type-only imports/exports, so the flag can now be centralized in the base config. Removes the now-redundant per-package overrides; keeps the explicit 'false' in http-client-js/tsconfig.test.json (generated e2e fixtures).
Contributor
|
@FionaBronwen @swatkatz @steverice — this PR modifies files in the |
microsoft-github-policy-service
Bot
added
emitter:graphql
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the
verbatimModuleSyntaxrollout by turning the flag on centrally intsconfig.base.json, so every package inherits it instead of opting in individually.Now that all workspace packages and the three standalone client emitters (C#/Java/Python) have been converted to type-only imports/exports, the per-package overrides are redundant. This PR:
"verbatimModuleSyntax": truetotsconfig.base.json.verbatimModuleSyntax: trueoverrides (48 tsconfigs).verbatimModuleSyntax: falseinpackages/http-client-js/tsconfig.test.json(generated e2e fixtures that aren't emitted with type-only imports).No runtime behavior change — a dev-only TypeScript configuration change.
Depends on the per-package rollout PRs having merged first (#11484, #11510, #11512, #11513, #11514, #11515, #11516, #11517).