git: fix wrong value used when migrating user inputValidation setting#309173
Open
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Open
git: fix wrong value used when migrating user inputValidation setting#309173yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
When migrating the legacy string-based `git.inputValidation` user setting to the new boolean form, the code incorrectly checked `workspaceValue` instead of `globalValue` to determine the new boolean value. This meant the global (user) setting was being migrated based on the workspace setting value rather than the actual user setting value.
1066d29 to
013ca13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When migrating the legacy string-based
git.inputValidationsetting to the new boolean form, the user (global) setting migration incorrectly readworkspaceValueinstead ofglobalValueto compute the new boolean.This meant that if someone had a workspace setting but not a user setting, the migration would still run (since
globalValueis checked for thetypeofguard), but would use the workspace value instead of the user value, producing incorrect results.Before:
After:
Fixes the copy-paste mistake introduced in the migration helper.