terminal: fix misleading 'failed to launch' message for fast-completing processes#309177
Open
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Open
terminal: fix misleading 'failed to launch' message for fast-completing processes#309177yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…ng processes On fast systems, processes that complete quickly (e.g. a build command that exits with a compiler error) were shown the 'failed to launch' message because they exited before the 500ms launch threshold elapsed. Track whether the process produced any output. If output was received, the process launched successfully regardless of timing, so use the correct 'terminated with exit code' message instead. Fixes microsoft#307400
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a terminal process exits while in the
Launchingstate, VS Code uses the "failed to launch" error message. However, this state is based on a 500ms threshold—on fast systems, processes that complete within that window (e.g. a build task that fails with a compiler error) incorrectly show "The terminal process failed to launch" instead of the accurate "The terminal process terminated with exit code: N".Fix: Track whether the process produced any output (
_hasReceivedProcessOutput). If output was received before exit, the shell launched successfully regardless of timing, so the correct "terminated with exit code" message is shown.Fixes #307400