fix(emmet): pass syntax hint to extractAbbreviation in expandEmmetAbbreviation#309181
Open
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(emmet): pass syntax hint to extractAbbreviation in expandEmmetAbbreviation#309181yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…breviation expansion When expanding Emmet abbreviations via Tab in languages mapped to HTML (e.g. ERB mapped to HTML via emmet.includeLanguages), dot-class shortcuts like `.something` were expanded to `.<div class="something"></div>` instead of `<div class="something"></div>`. The root cause was that extractAbbreviation() was called without a `syntax` option, causing the helper to use default extraction behavior that does not include the leading `.` in the abbreviation range. The completion provider already passes `syntax: 'markup'` or `syntax: 'stylesheet'` correctly; this change aligns the Tab expansion path with the same approach. Fixes microsoft#233969
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream fix for #233969
Problem
When a language is mapped to HTML via
emmet.includeLanguages(e.g."erb": "html"), typing a class abbreviation like.fooand pressing Tab fails to expand it. The abbreviation extractor picks up an empty or incorrect range because it does not know whether to apply stylesheet or markup extraction rules.Root Cause
expandEmmetAbbreviationcallshelper.extractAbbreviation(...)without thesyntaxoption, so the helper defaults to markup mode for all documents — including stylesheet languages — and vice versa. Compare withdefaultCompletionProvider.tswhich already passes the correctsyntaxvalue:Fix
Add the same
syntaxoption to theextractAbbreviationcall insideexpandEmmetAbbreviation:This is a one-line change that aligns
expandEmmetAbbreviationwith the existing behaviour indefaultCompletionProvider.ts.