Align compact activity bar chip size and spacing with top/bottom - #325423
Open
cipheraxat wants to merge 2 commits into
Open
Align compact activity bar chip size and spacing with top/bottom#325423cipheraxat wants to merge 2 commits into
cipheraxat wants to merge 2 commits into
Conversation
Match Modern UI compact side indicators to the 24×24 horizontal chips and apply a 4px item gap so compact mode stays consistent across activity bar positions.
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns compact side activity bar chips and spacing with top/bottom layouts.
Changes:
- Resizes active and hover chips to 24×24.
- Uses the control-tier radius and 4px item spacing.
- Enables vertical flex layout so spacing applies.
Reset inherited bottom/margin so the 24px active indicator stays at top: 4px.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #325127
Summary
In Modern UI compact mode, the side activity bar's selected/hover chips were 28×28 with a larger radius, while the top/bottom activity bar uses 24×24 chips with
cornerRadius-small. Item spacing was also off on the side because the vertical action bar usesdisplay: inline-block, so CSSgapnever applied.This brings the compact side bar in line with top/bottom: 24×24 chips, matching radius, and a 4px gap between items.
Changes
In
activityBar.css:cornerRadius-small(same as horizontal).actions-containerto a column flex layout sogap: 4pxworksbottom/marginon the active chip so it aligns with hover attop: 4pxScreenshots
Before — compact side (28×28, no gap)
Before — top (24×24 reference)
After — compact side (24×24, 4px gap)
After — top (unchanged)
Full workbench
Before:
After:
How to test
"workbench.experimental.modernUI": true