Recognise OCaml in settings labels#325457
Open
smorimoto wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds official OCaml capitalization to settings labels without changing configuration keys.
Changes:
- Maps
ocamltoOCamlduring label formatting. - Adds regression coverage for nested OCaml settings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/preferences/common/preferences.ts |
Adds the OCaml term mapping. |
src/vs/workbench/contrib/preferences/test/browser/settingsTreeModels.test.ts |
Verifies nested OCaml label formatting. |
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @rzhao271Matched files:
|
ulugbekna
approved these changes
Jul 12, 2026
ulugbekna
left a comment
ulugbekna
left a comment
Contributor
There was a problem hiding this comment.
Lgtm, thanks @smorimoto ! ;)
@rzhao271 hope it's ok to approve
aeschli
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ocamlas theOCamlterm when formatting settings labelsConfiguration keys such as
ocaml.server.extendedHoverare currently rendered asOcaml › Server: Extended Hover. This change uses the officialOCamlspelling while leaving configuration keys unchanged.@ulugbekna, could you please have a look? This affects the presentation of settings contributed by the OCaml extension.
Testing
npm run typecheck-clientnpm run gulp compile-client./scripts/test.sh --grep 'settingKeyToDisplayFormat - known acronym/term'npm run eslint -- src/vs/workbench/contrib/preferences/common/preferences.ts src/vs/workbench/contrib/preferences/test/browser/settingsTreeModels.test.ts