fix(extensions): remove global Disable action if extension is already disabled globally#325463
Draft
singhlovepreet9 wants to merge 1 commit into
Draft
fix(extensions): remove global Disable action if extension is already disabled globally#325463singhlovepreet9 wants to merge 1 commit into
singhlovepreet9 wants to merge 1 commit into
Conversation
… disabled globally Fixes microsoft#244138
| } | ||
| this.enabled = this.extension.state === ExtensionState.Installed | ||
| && (this.extension.enablementState === EnablementState.EnabledGlobally || this.extension.enablementState === EnablementState.EnabledWorkspace) | ||
| && (this.extension.enablementState === EnablementState.EnabledGlobally || (this.extension.enablementState === EnablementState.EnabledWorkspace && !this.extensionEnablementService.isDisabledGlobally(this.extension.local))) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #244138
When an extension is disabled globally and then enabled for a workspace, the
DisableGloballyActionwould still be enabled, causing the dropdown to show bothDisableandDisable (Workspace).This PR updates
DisableGloballyAction.update()to check!this.extensionEnablementService.isDisabledGlobally(this.extension.local)when the extension's state isEnabledWorkspace. This ensures the global Disable action is hidden if the extension is already globally disabled, leaving only theDisable (Workspace)button as expected.