Skip to content

Add setting for installer log file names#5802

Merged
JohnMcPMS merged 7 commits intomicrosoft:masterfrom
Trenly:LogName
Apr 28, 2026
Merged

Add setting for installer log file names#5802
JohnMcPMS merged 7 commits intomicrosoft:masterfrom
Trenly:LogName

Conversation

@Trenly
Copy link
Copy Markdown
Contributor

@Trenly Trenly commented Oct 14, 2025

Sometimes the Manifest name is just too long. While I would love to be able to give users the ability to control the format directly using token replacement and all sorts of other cool stuff, that's a bit much for right now.

To help alleviate the issue, I've added a setting that controls how installer file names are generated. With this change, instead of being forced into the Package ID and version with timestamp, it is now possible to have the default installer log name be shorter. While this doesn't actually resolve the issue, it does make it possible to at least mitigate

  • Manifest - Default, matches current behavior
  • Timestamp - Includes just the timestamp as the installer log name
  • GUID - Creates a new GUID and uses that as the installer log name
  • ShortGuid - Creates a new GUID and uses the first 8 characters as the installer log name

Note that this only affects the installer log name, not the WinGet log name, and only for installers which support passing of the log name. This PR does not affect the behavior of --log <location>


Microsoft Reviewers: Open in CodeFlow

@github-actions

This comment has been minimized.

@Trenly Trenly marked this pull request as draft October 29, 2025 17:53
@Trenly Trenly force-pushed the LogName branch 2 times, most recently from e3e4014 to 81d76e6 Compare October 29, 2025 18:56
@Trenly Trenly marked this pull request as ready for review October 29, 2025 18:57
@Trenly
Copy link
Copy Markdown
Contributor Author

Trenly commented Dec 17, 2025

Marking as draft to fix merge conflicts

@Trenly Trenly marked this pull request as draft December 17, 2025 14:58
@Trenly Trenly marked this pull request as ready for review April 28, 2026 14:37
@Trenly Trenly requested a review from a team as a code owner April 28, 2026 14:37
@Trenly
Copy link
Copy Markdown
Contributor Author

Trenly commented Apr 28, 2026

Finally got around to fixing the merge conflicts.

Interesting note, if this gets merged, it will push the repo over 1000 unit tests :D

===============================================================================
All tests passed (28169 assertions in 1000 test cases)

@JohnMcPMS
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JohnMcPMS JohnMcPMS merged commit 9bc432c into microsoft:master Apr 28, 2026
9 checks passed
@Trenly Trenly deleted the LogName branch April 28, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants