-
Notifications
You must be signed in to change notification settings - Fork 7
refactor: introduce WinMLManifest dataclass as single source of truth for build_manifest.json #1057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
23363bb
1st round
xieofxie 341d3ff
clear sidecar
xieofxie 7620ea7
fix(export): flat stem-suffixed composite layout; surface resolution …
xieofxie 1610658
fix(export): guard composite paths up front, surface detection errors…
xieofxie d774ca1
rename to winml_manifest.json
8d9abe4
1st iter
f8f60af
Merge remote-tracking branch 'origin/main' into hualxie/winmlcli_mani…
ea542d2
fix: resolve ruff lint errors in test_manifest.py
bb7d749
fix: add missing imports in test_composite_partial_export
d883a3a
Merge remote-tracking branch 'origin/main' into hualxie/winmlcli_mani…
c3c4d28
address PR #1057 review: fix missed rename, remove dead code, add tests
8aae94c
restore default=str safety net in manifest save()
489a549
rename manifests: build_manifest.json for build, export_manifest.json…
f53f56d
Merge remote-tracking branch 'origin/main' into hualxie/winmlcli_mani…
dc4fce4
handle numpy scalars in _sanitize_value
6b8579d
add explanatory comment to ImportError except clause (CodeQL)
d2221e5
remove try-catch around numpy import (numpy is a required dependency)
0d18e52
remove export manifest generation to keep PR as pure refactor
b5f83f2
wire consumers to use WinMLManifest and MANIFEST_FILENAME constant
391a89a
default source/final_artifact to None, widen exception handling
f2a1d39
address review: hoist numpy import, preserve schema_version, drop man…
0e179f2
clarify schema_version handling in to_dict: pop from raw instead of s…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.