♻️ rework HTTP classes - #478
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the V1 HTTP endpoint classes to share common behavior via a new BaseEndpoint, and broadens the supported undici version range to include 8.x.
Changes:
- Introduce
BaseEndpointinsrc/v1/http/and migrate V1 endpoint classes to extend it. - Move the V1-specific
cutDocPagesbehavior out of the generalsrc/http/apiCore.tsinto the V1 HTTP layer. - Update
undicidependency constraints (and lockfile resolution) to allow 8.x.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/v1/http/workflowEndpoint.ts | Migrates workflow endpoint to extend the new shared V1 base endpoint. |
| src/v1/http/endpoint.ts | Migrates product endpoint to extend the new shared V1 base endpoint and reuses shared page-cutting logic. |
| src/v1/http/baseEndpoint.ts | Adds shared V1 endpoint base class and moves V1-specific cutDocPages there. |
| src/http/apiCore.ts | Removes V1-specific cutDocPages helper from general HTTP core utilities. |
| package.json | Broadens undici allowed range to include 8.x. |
| package-lock.json | Updates lockfile resolution to undici@8.10.0 and other transitive dependency updates. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot stopped work on behalf of
ianardee due to an error
August 19, 2026 10:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move V1 specific method from general namespace to V1 namespace.
Types of changes