Skip to content

♻️ rework HTTP classes - #478

Merged
ianardee merged 1 commit into
mainfrom
rework-http
Aug 19, 2026
Merged

♻️ rework HTTP classes#478
ianardee merged 1 commit into
mainfrom
rework-http

Conversation

@ianardee

@ianardee ianardee commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Description

Move V1 specific method from general namespace to V1 namespace.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the V1 HTTP endpoint classes to share common behavior via a new BaseEndpoint, and broadens the supported undici version range to include 8.x.

Changes:

  • Introduce BaseEndpoint in src/v1/http/ and migrate V1 endpoint classes to extend it.
  • Move the V1-specific cutDocPages behavior out of the general src/http/apiCore.ts into the V1 HTTP layer.
  • Update undici dependency constraints (and lockfile resolution) to allow 8.x.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/v1/http/workflowEndpoint.ts Migrates workflow endpoint to extend the new shared V1 base endpoint.
src/v1/http/endpoint.ts Migrates product endpoint to extend the new shared V1 base endpoint and reuses shared page-cutting logic.
src/v1/http/baseEndpoint.ts Adds shared V1 endpoint base class and moves V1-specific cutDocPages there.
src/http/apiCore.ts Removes V1-specific cutDocPages helper from general HTTP core utilities.
package.json Broadens undici allowed range to include 8.x.
package-lock.json Updates lockfile resolution to undici@8.10.0 and other transitive dependency updates.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread package.json Outdated
Comment thread src/v1/http/endpoint.ts
@ianardee ianardee changed the title ♻️ rework HTTP classes, update undici ♻️ rework HTTP classes Aug 19, 2026
@ianardee
ianardee merged commit 32ace70 into main Aug 19, 2026
59 of 67 checks passed
@ianardee
ianardee deleted the rework-http branch August 19, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants