fix WPF relative resource renaming#565
Open
ryanroe wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
Fixes WPF relative resource renaming by correcting how file names are extracted and passed to the rename method. The change addresses issue #550 by ensuring that only the filename portion (without directory path) is used for renaming operations.
- Extracts filename portion separately from directory path calculation
- Updates rename calls to use filename instead of full path
- Improves variable naming for clarity
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Jun 7, 2026
mcpolo99
pushed a commit
to mcpolo99/ConfuserExx
that referenced
this pull request
Jun 7, 2026
Cherry-pick of mkaring#565. Fixes relative resource path handling in WPF ResourceDictionary entries by passing relative file names (not full paths) to bamlRef.Rename(), ensuring BAML references using relative URIs are correctly updated during renaming. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #550