Repository navigation
[Server] Apply the client-set log level in ClientGateway::log() - #571
Open
chr-hertel wants to merge 3 commits into
Open
chr-hertel wants to merge 3 commits into
chr-hertel wants to merge 3 commits into
Conversation
chr-hertel
added
bug
chr-hertel
force-pushed
the
fix-client-gateway-log-level
branch
from
October 10, 2026 02:10
9a7e378 to
6a7010e
Compare
chr-hertel
removed
the
on hold
chr-hertel
marked this pull request as ready for review
October 10, 2026 02:10
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
October 10, 2026 02:10
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
logging/setLevel(error),ClientGateway::log(LoggingLevel::Warning, ...)was still sent, whileClientLoggerdropped the same message.ClientGateway::log()readsProtocol::SESSION_LOGGING_LEVEL(default warning) and drops anything below itClientLoggerjust delegates -[BC Break]it takes only theClientGatewaynowStacked on #566 (a963cf1 seeds
SESSION_LOGGING_LEVELfrom_metaon2026-07-28) - merge after it, only the last commit belongs here.Fixes chr-hertel#61
🤖 Generated with Claude Code