Repository navigation
[Server] Fix stdio answering a request on an idle connection only after ~50ms - #575
Merged
chr-hertel merged 2 commits intoOct 13, 2026
Merged
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
October 10, 2026 01:56
chr-hertel
added
bug
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new process-based unit test must skip environments where proc_open() is disabled.
1 open finding
What changed in this PR
Replaces stdio polling sleeps with selectable input waits to reduce idle-request latency.
Changes:
- Adds a 50ms-capped
stream_select()wait with fallback. - Adds latency regression coverage.
- Documents the fix in the changelog.
| File | Description |
|---|---|
src/Server/Transport/StdioTransport.php |
Adds interruptible input waiting. |
tests/Unit/Server/Transport/StdioTransportTest.php |
Tests idle-input wake-up latency. |
CHANGELOG.md |
Records the latency fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
chr-hertel
force-pushed
the
fix-stdio-idle-latency
branch
from
October 12, 2026 20:56
3860c21 to
20d6dd5
Compare
soyuka
previously approved these changes
Oct 13, 2026
chr-hertel
force-pushed
the
fix-stdio-idle-latency
branch
from
October 13, 2026 21:27
20d6dd5 to
9df0acb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stdio loop slept 50ms whenever no complete line was there, so a sequential client got ~20 calls/s at most.
stream_select()instead, still capped at 50ms so fibers, streams and queued messages get their tickphp://memoryfall back to the sleepFixes chr-hertel#63
🤖 Generated with Claude Code