Repository navigation
[Client] Fix connecting to a server with an empty serverInfo.version - #579
Open
chr-hertel wants to merge 1 commit into
Open
chr-hertel wants to merge 1 commit into
chr-hertel wants to merge 1 commit into
Conversation
Accept an empty `serverInfo.version`, and close the transport when initialization fails on a malformed result, wrapped in a `ConnectionException`.
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
October 10, 2026 01:57
chr-hertel
added
bug
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python SDK sends
"version": ""when the server has none configured -connect()failed with anInvalidArgumentExceptionand left a spawned stdio server running.Implementation::fromArray()accepts an emptyversion, the spec only types it as string - missing or non-string is still rejectedconnect()closes the transport on any SDK exception during initialization and wraps it in aConnectionException, without retrying since a malformed result is not transientFixes chr-hertel#70
🤖 Generated with Claude Code