Skip to content

test: improve tests stability#3136

Merged
bashmish merged 3 commits into
masterfrom
test/improve-reload-test-stability
Jul 22, 2026
Merged

test: improve tests stability#3136
bashmish merged 3 commits into
masterfrom
test/improve-reload-test-stability

Conversation

@bashmish

@bashmish bashmish commented Jul 16, 2026

Copy link
Copy Markdown
Member

What I did

Improved test stability, mainly in Windows, but also in Node.

Unfortunately not all tests were fixed and I still observe random failures on Windows, much less on Node.
I see that many of our tests depend on magical timers. I figured that on Windows the timer resolution (or "tick") is 15.625 ms which is really long as compared to Unix systems, where it's 1 second IIUC (didn't thoroughly checked this for all possible OS, but in our case I think it's reflecting current situation quite well). Therefore what we often consider to be a Windows issue is not necessarily a Windows issue, just the possibility of it being flaky on Windows is many times higher.
Some tests depends on the tick to be shorter than 15ms, then it's a Windows-only flaky test, I fixed a few of those which failed very often.
Overall it's hard to say how many tests are still flaky, I was able to see 3 random places in tests which failed today on Windows after my fixes, at some point I had to proceed to other tasks, can't continue on this, especially because I don't have a local Windows machine for testing.

@changeset-bot

changeset-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0f5cfec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bashmish bashmish changed the title test: improve reload test stability test: improve tests stability Jul 22, 2026
@bashmish
bashmish force-pushed the test/improve-reload-test-stability branch 3 times, most recently from ef9173e to d832183 Compare July 22, 2026 10:22
@bashmish
bashmish force-pushed the test/improve-reload-test-stability branch 2 times, most recently from 5bd89be to 01b2734 Compare July 22, 2026 12:40
@bashmish
bashmish force-pushed the test/improve-reload-test-stability branch from 01b2734 to 0f5cfec Compare July 22, 2026 14:41
@bashmish
bashmish merged commit a7972ab into master Jul 22, 2026
7 checks passed
@bashmish
bashmish deleted the test/improve-reload-test-stability branch July 22, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant