Skip to content

feat: add script to check transitive deps COMPASS-10569#633

Open
lerouxb wants to merge 15 commits intomainfrom
check-transitive-deps
Open

feat: add script to check transitive deps COMPASS-10569#633
lerouxb wants to merge 15 commits intomainfrom
check-transitive-deps

Conversation

@lerouxb
Copy link
Copy Markdown
Member

@lerouxb lerouxb commented Apr 14, 2026

COMPASS-10569

Here it is on Compass: https://gist.github.com/lerouxb/d076c160f49cc1973db0490cab2bcf2a

We probably want to run it with --ignore-dev-deps. Without it is a convenient way to get errors during testing, though.

@mongodb-js mongodb-js deleted a comment from coveralls Apr 14, 2026
@@ -0,0 +1,9 @@
{
"deps": [
Copy link
Copy Markdown
Member Author

@lerouxb lerouxb Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything else we want to keep aligned? Running this with just ["*"] is kinda hilarious.

@lerouxb lerouxb marked this pull request as ready for review April 15, 2026 06:31
}
}

describe('getPackagesInTopologicalOrder', function () {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added these tests as a drive-by because coveralls was complaining about it and that coverage is down. Then I convinced myself that I started importing this from tests which made it reachable and counted towards coverage... But I think that code's gone if it was ever the case.

Anyway. Here are some tests for it of dubious quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant