Fix plain text links in citations - #1022
Open
aakashsbhatia2 wants to merge 3 commits into
Open
Conversation
gijsk
requested changes
Jul 28, 2026
gijsk
left a comment
gijsk
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR!
This looks interesting and the change makes sense to me. My main question is whether we really need the argument - do we not want to count the plaintext links for all _getLinkDensity callers? If not, why not? :-)
| **/ | ||
| _getLinkDensity(element) { | ||
| _getLinkDensity(element, includePlainTextUrls) { | ||
| var textLength = this._getInnerText(element).length; |
Contributor
There was a problem hiding this comment.
Let's maybe cache the return of getInnerText which may not be cheap for large nodes, given we now potentially reuse it further down?
Contributor
|
Oh, and one minor thing - can we strip scripts from the input HTML to avoid accidentally running them when checking testcases? Thank you! (if the generate testcase script doesn't do this, it wouldn't hurt to change that... though obviously that's a separate problem) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue - #1016
It seems like the issue is in the scoring algorithm. The end links are scored higher than the article content causing it to take precedence. I updated
_getLinkDensity()to consider urls not wrapped in<a>tags as well. Added the source as a test case