Repository navigation
Fix -Wshadow warning in fix_int's constructor - #1189
Merged
Merged
Conversation
The constructor parameter shadowed the member of the same name, which GCC reports with -Wshadow in every file that includes <msgpack.hpp>.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## cpp_master #1189 +/- ##
==============================================
- Coverage 85.36% 79.81% -5.56%
==============================================
Files 80 80
Lines 5099 5790 +691
Branches 507 629 +122
==============================================
+ Hits 4353 4621 +268
- Misses 746 1169 +423 🚀 New features to boost your workflow:
|
Contributor
|
@kkaefer , Thank you for sending the PR. It looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constructor parameter shadowed the member of the same name, which GCC reports with
-Wshadowin every file that includesmsgpack.hpp.