Fix settings restart prompt lost after language/skin change - #5072
Open
QueryOfficial wants to merge 1 commit into
Open
Fix settings restart prompt lost after language/skin change#5072QueryOfficial wants to merge 1 commit into
QueryOfficial wants to merge 1 commit into
Conversation
|
Thank you for fixing the bugfix, as I started encountering this bug with the latest 1.6 build. It's a good thing I added the issues to the bugfix wait list. |
Contributor
Author
I follow the issues created in my free time and try to address them as much as I can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Persist the settings "restart required" prompt across Interface tab locale/skin rebuilds so changing resolution (or other restart-required options) still prompts after switching language/skin.
Previously
ShowRestartQuestion()showed aQuestionBoxowned byMainMenu. Changing language or skin destroys and recreatesMainMenu, which dropped that prompt. The restart requirement is now tracked onCLocalGUIand re-shown after the UI rebuild.Motivation
Fixes #5063
When a user changed screen resolution in Video settings, then switched to the Interface tab and changed language (or skin), closing settings no longer asked to restart — even though the resolution change still required one.
Root cause: locale/skin changes call
DestroyWindows()/CreateWindows(), which replacesMainMenuand itsQuestionBox, so the restart dialog was lost and never restored.Test plan
Checklist