Fix hydraulics not working on monster trucks - #5159
Open
TheCrazy17 wants to merge 1 commit into
Open
Conversation
CAutomobile::HydraulicControl treated monster trucks as ordinary cars and fought CMonsterTruck's own suspension model over the same fields every frame, so this recreates the same hydraulics control scheme aimed at CMonsterTruck's own suspension travel instead, which the truck raises and lowers by sliding that whole travel window relative to the chassis rather than by moving the wheel position directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Monster trucks now get working hydraulics. The horn raises and lowers the truck, the hydraulic jump button hops every wheel at once, and the right stick tilts it, the same control scheme lowriders already have.
Motivation
Fixes #1743. CAutomobile::HydraulicControl treated monster trucks as ordinary cars and fought CMonsterTruck's own suspension model over the same fields every frame, which is what broke their suspension when the upgrade was installed.
Test plan
Install the hydraulics upgrade on a monster truck and confirm it behaves just like a lowrider: the horn raises and lowers it, the jump button hops it, and the stick tilts it while raised, with no suspension breaking.
Checklist