Skip to content

Vendor static Swagger UI 5.32.14 - #2996

Merged
ktsaou merged 1 commit into
masterfrom
maintenance/learn-swagger-ui-v5.32.14
Aug 21, 2026
Merged

Vendor static Swagger UI 5.32.14#2996
ktsaou merged 1 commit into
masterfrom
maintenance/learn-swagger-ui-v5.32.14

Conversation

@ktsaou

@ktsaou ktsaou commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary

  • Replace the active Swagger UI 4.18.1 static distribution with the official 5.32.14 artifact.
  • Record exact Yarn resolution, registry integrity, source hashes, and the allowed title-only OAuth redirect overlay.
  • Fail the Netlify build when the static distribution drifts from its locked package source.

Validation

  • yarn install --frozen-lockfile --force
  • yarn test:run
  • yarn build:netlify twice, including all post-build and owner-controlled vendor gates
  • byte-for-byte deterministic production output across 4,163 files

Remaining manual check

Browser automation is unavailable in this environment. The built api artifact and every local asset were verified byte-for-byte, but the draft should receive a browser smoke test of /api before merge.


Summary by cubic

Vendors the Swagger UI static bundle to 5.32.14 and locks its provenance to swagger-ui-dist. Previously we shipped 4.18.1 without a verification gate; now a vendor contract verifies hashes/resolution and the Netlify build fails on drift. The OAuth redirect page now loads oauth2-redirect.js and includes a non-empty title; redirect behavior is unchanged.

  • Review and rollout
    • Gate and contract: scripts/verify-swagger-ui-vendor.js enforces static/swagger-ui-vendor.json (Yarn resolution, integrity, and SHA‑256 for all published files).
    • Build changes: build:netlify runs the vendor verification before the site build gate; tests cover ordering and contract validation.
    • Dependency and commands: adds exact swagger-ui-dist@5.32.14. To upgrade later, bump the version, run yarn vendor:swagger-ui, then yarn test:swagger-ui-vendor.
    • HTML change: static/oauth2-redirect.html now references oauth2-redirect.js; the only local overlay is the title recorded in the contract.
    • Rollout: run a quick browser smoke test of /api before merge.

Written for commit fe7ad4f. Summary will update on new commits.

Review in cubic

@netlify

netlify Bot commented Aug 21, 2026

Copy link
Copy Markdown

Deploy Preview for netdata-docusaurus ready!

Name Link
🔨 Latest commit fe7ad4f
🔍 Latest deploy log https://app.netlify.com/projects/netdata-docusaurus/deploys/6a889a3dc422b800084d8922
😎 Deploy Preview https://deploy-preview-2996--netdata-docusaurus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ktsaou, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3a2966d2-89d6-41f5-b015-c1916b81029e

📥 Commits

Reviewing files that changed from the base of the PR and between 016a10a and fe7ad4f.

⛔ Files ignored due to path filters (7)
  • static/swagger-ui-bundle.js.map is excluded by !**/*.map
  • static/swagger-ui-es-bundle-core.js.map is excluded by !**/*.map
  • static/swagger-ui-es-bundle.js.map is excluded by !**/*.map
  • static/swagger-ui-standalone-preset.js.map is excluded by !**/*.map
  • static/swagger-ui.css.map is excluded by !**/*.map
  • static/swagger-ui.js.map is excluded by !**/*.map
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (18)
  • README.md
  • package.json
  • scripts/verify-swagger-ui-vendor.js
  • src/seo/deploymentIntegrations.test.js
  • static/oauth2-redirect.html
  • static/oauth2-redirect.js
  • static/swagger-ui-bundle.js
  • static/swagger-ui-bundle.js.LICENSE.txt
  • static/swagger-ui-es-bundle-core.js
  • static/swagger-ui-es-bundle-core.js.LICENSE.txt
  • static/swagger-ui-es-bundle.js
  • static/swagger-ui-es-bundle.js.LICENSE.txt
  • static/swagger-ui-standalone-preset.js
  • static/swagger-ui-standalone-preset.js.LICENSE.txt
  • static/swagger-ui-vendor.json
  • static/swagger-ui.css
  • static/swagger-ui.js
  • tests/swagger_ui_vendor.test.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ktsaou
ktsaou marked this pull request as ready for review August 21, 2026 19:26
@ktsaou
ktsaou merged commit b47049c into master Aug 21, 2026
7 of 8 checks passed
@ktsaou
ktsaou deleted the maintenance/learn-swagger-ui-v5.32.14 branch August 21, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant