Skip to content

toggleForm validates rules of hidden items #286

New issue
New issue
Closed as not planned
Closed as not planned
toggleForm validates rules of hidden items#286

Description

@TheLegs
TheLegs
opened on Apr 27, 2022

Version: 3.1.6

Bug Description

When there are toggle rules nested into elements which are in turn subjects of possible toggling, a specific situation may occur where, if a value was set while the item was displayed, but then the item is hidden, toggleForm() will continue to evaluate those rules against the hidden items. The consequence is that, for example, certain items keep being displayed when they should not be, or the user might not be able to submit a form due to a validation issue on an item that is hidden.

Steps To Reproduce

Set for example the following radio buttons:

  • item1 with a rule to toggle item2 on a certain value
  • item2 with a rule to toggle item3
  • item4 with a rule to toggle item3, and
  • item5 that has no toggle rules set

Then select item1 in order to toggle item2, then item2 in order to toggle item3.
Lastly, select item5.

Expected Behavior

When selecting item5, you should no longer see item3.

Possible Solution

toggleForm() should only call toggleControl() on controls that currently displayed.
Plus, I think the controls should be also reset when toggled out, to prevent data from being submitted unbeknownst to the user.

forms/src/assets/netteForms.js

Lines 611 to 616 in ffdffaa

for (i = 0; i < form.elements.length; i++) {
if (form.elements[i].tagName.toLowerCase() in {input: 1, select: 1, textarea: 1, button: 1}) {
Nette.toggleControl(form.elements[i], null, null, !event);
}
}

Activity

  1. dg commented on Oct 28, 2026

    @dg
    dg
    on Oct 28, 2026
    Member

    The dependency can be stated explicitly by nesting the condition, which is also how the server evaluates it:

    $b->addConditionOn($a, Form::Equal, 1)
	->addCondition(Form::Equal, 'x')
		->toggle('box3');

    Validating hidden controls is intentional, since the server doesn't know about visibility either, and resetting values on hide would silently destroy user input.

  2. dg
    closed this as not plannedon Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions