Update upload icon, use outlined variant for upload-folder#2099
Merged
Conversation
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2099 +/- ##
=======================================
Coverage 36.30% 36.30%
=======================================
Files 17 17
Lines 774 774
Branches 145 145
=======================================
Hits 281 281
Misses 480 480
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skjnldsv
approved these changes
May 29, 2026
jancborchardt
requested changes
Jun 2, 2026
jancborchardt
left a comment
Contributor
There was a problem hiding this comment.
Changing the folder icon looks nice, but the upload icon looks a bit too complex, different style and also has a different arrow than the folder upload icon.
The changed folder icon works well with the existing file upload icon though, so I’d say only changing the folder icon would be nice. :)
jancborchardt
approved these changes
Jun 2, 2026
jancborchardt
left a comment
Contributor
There was a problem hiding this comment.
Nevermind, we already use that upload icon in a bunch of places. :)
Contributor
Ok let's go then 👍👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't have / have no easy way for screenshots
but if you open the menu in any instance.