Skip to content

Update upload icon, use outlined variant for upload-folder#2099

Merged
skjnldsv merged 2 commits into
mainfrom
style/noid/icons
Jun 6, 2026
Merged

Update upload icon, use outlined variant for upload-folder#2099
skjnldsv merged 2 commits into
mainfrom
style/noid/icons

Conversation

@AndyScherzinger

Copy link
Copy Markdown
Contributor

I don't have / have no easy way for screenshots

but if you open the menu in any instance.

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews design Related to the design labels May 29, 2026
@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.30%. Comparing base (ca42079) to head (e6530fc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2099   +/-   ##
=======================================
  Coverage   36.30%   36.30%           
=======================================
  Files          17       17           
  Lines         774      774           
  Branches      145      145           
=======================================
  Hits          281      281           
  Misses        480      480           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the folder icon looks nice, but the upload icon looks a bit too complex, different style and also has a different arrow than the folder upload icon.

The changed folder icon works well with the existing file upload icon though, so I’d say only changing the folder icon would be nice. :)

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, we already use that upload icon in a bunch of places. :)

@skjnldsv skjnldsv merged commit ff8d1d8 into main Jun 6, 2026
18 of 22 checks passed
@skjnldsv skjnldsv deleted the style/noid/icons branch June 6, 2026 04:35
@skjnldsv

skjnldsv commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Nevermind, we already use that upload icon in a bunch of places. :)

Ok let's go then 👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Related to the design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants