Skip to content

Fix R8 and ProGuard documentation - #1066

Open
Abhijeet-035 wants to merge 2 commits into
nextcloud:mainfrom
Abhijeet-035:fix/r8-readme
Open

Abhijeet-035 wants to merge 2 commits into
nextcloud:mainfrom
Abhijeet-035:fix/r8-readme

Conversation

@Abhijeet-035

Copy link
Copy Markdown

Fixes #572

Updates the R8/ProGuard documentation to remove the recommendation to disable obfuscation with -dontobfuscate and clarifies that the required SSO rules are bundled with the library.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Signed-off-by: Abhijeet Kumar <jsrabhi819@gmail.com>
@github-actions

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Readme contains bad R8 advice

1 participant