Skip to content

Remove KAPT#16018

Merged
tobiasKaminsky merged 2 commits intomasterfrom
removeKAPT
Apr 15, 2026
Merged

Remove KAPT#16018
tobiasKaminsky merged 2 commits intomasterfrom
removeKAPT

Conversation

@tobiasKaminsky
Copy link
Copy Markdown
Member

@tobiasKaminsky tobiasKaminsky commented Nov 26, 2025

We use KAPT only for creating language for MarkwonGrammarLocator.
I now replaced it with pre-built version.

This saves on my machen 20s per each full run.

  • Tests written, or not not needed

github-advanced-security[bot]
github-advanced-security AI found potential problems Nov 26, 2025
View reviewed changes
Comment thread app/src/main/java/third_parties/io/noties/prism4j/languages/Prism_c.java
false,
"property",
grammar("inside",
token("string", pattern(compile("(#\\s*include\\s*)(?:<.+?>|(\"|')(?:\\\\?.)+?\\2)"), true)),

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with '#include"' and containing many repetitions of '\a'.
Comment thread app/src/main/java/third_parties/io/noties/prism4j/languages/Prism_javascript.java
token(
"template-string",
pattern(
compile("`(?:\\\\[\\s\\S]|\\$\\{[^}]+\\}|[^\\\\`])*`"),

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with '`' and containing many repetitions of '${[}'.
Comment thread app/src/main/java/third_parties/io/noties/prism4j/languages/Prism_swift.java
GrammarUtils.require(prism4j, "clike"),
"swift",
token("string", pattern(
compile("(\"|')(\\\\(?:\\((?:[^()]|\\([^)]+\\))+\\)|\\r\\n|[\\s\\S])|(?!\\1)[^\\\\\\r\\n])*\\1"),

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with '"\' and containing many repetitions of '(')\'.
AndyScherzinger
AndyScherzinger reviewed Dec 30, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added files currently ship the template SPDX header. Should update the copyright line on them.

@tobiasKaminsky
Copy link
Copy Markdown
Member Author

tobiasKaminsky commented Jan 5, 2026

Added files currently ship the template SPDX header. Should update the copyright line on them.

Done. Changed to their license as stated here: https://github.com/noties/Prism4j/blob/master/README.md#license

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 5, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16018.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96
Copy link
Copy Markdown
Collaborator

alperozturk96 commented Jan 12, 2026

This solves: #13050. @tobiasKaminsky Awesome 🚀

@alperozturk96
Copy link
Copy Markdown
Collaborator

alperozturk96 commented Feb 4, 2026 •
edited
Loading

@tobiasKaminsky Could you rebase to latest master, this is good improvement after this we can use builtInKotlin.

Since KAPT does not support builtInKotlin for now.

Reference: #16346

@tobiasKaminsky
Remove KAPT
bf9ada5 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Remove KAPT
f3e90cf 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness6969
Dodgy code226226
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total432432

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

APK file: https://github.com/nextcloud/android/actions/runs/24448091583/artifacts/6447854438
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@tobiasKaminsky tobiasKaminsky merged commit 329e4ff into master Apr 15, 2026
15 of 20 checks passed
@tobiasKaminsky tobiasKaminsky deleted the removeKAPT branch April 15, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger left review comments

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tobiasKaminsky @alperozturk96 @AndyScherzinger @github-advanced-security