Skip to content

fix(oc-capability): uses correct room field types#16781

Open
alperozturk96 wants to merge 3 commits intomasterfrom
fix/oc-capability-entry-type
Open

fix(oc-capability): uses correct room field types#16781
alperozturk96 wants to merge 3 commits intomasterfrom
fix/oc-capability-entry-type

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 commented Mar 30, 2026 •
edited
Loading

Fixes

forbiddenFileNameCharacters, forbiddenFileNames, forbiddenFileNameExtensions, forbiddenFilenameBaseNames

This PR fixes an inconsistency where several capabilities columns were defined as INTEGER in Room but actually stored JSON String values.

Why it previously worked

Data was read via cursor (getString), bypassing Room’s type mapping

Changes

Updated affected fields in CapabilityEntity from Int? to String?
Added a migration that drops the capabilities table to ensure a clean schema
Adds capability dao and mapping between entity and OCCapability

@alperozturk96 alperozturk96 added this to the Nextcloud App 33.1.0 milestone Mar 30, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

APK file: https://github.com/nextcloud/android/actions/runs/23749644834/artifacts/6180479612
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 force-pushed the fix/oc-capability-entry-type branch from efc5183 to 558ed56 Compare April 8, 2026 07:08
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

APK file: https://github.com/nextcloud/android/actions/runs/24122694656/artifacts/6322219923
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
Copy link
Copy Markdown
Collaborator Author

alperozturk96 commented Apr 14, 2026

/backport to stable-33.1.0

@alperozturk96
fix(oc-capability): uses correct room field types
4d94b81 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/schemas/com.nextcloud.client.database.NextcloudDatabase/99.json
#	app/src/main/java/com/nextcloud/client/database/NextcloudDatabase.kt
@alperozturk96
fix codacy
328102d 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add migration
bb4c135 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/oc-capability-entry-type branch from 558ed56 to bb4c135 Compare April 14, 2026 08:22
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness6969
Dodgy code227227
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total433433

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

APK file: https://github.com/nextcloud/android/actions/runs/24388735581/artifacts/6423422154
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review backport-request

Projects

None yet

Milestone

Nextcloud App 33.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @AndyScherzinger