Skip to content

fix(file-list): browse up#16848

Merged
alperozturk96 merged 6 commits intomasterfrom
fix/file-list-on-browse-up
Apr 15, 2026
Merged

fix(file-list): browse up#16848
alperozturk96 merged 6 commits intomasterfrom
fix/file-list-on-browse-up

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 commented Apr 14, 2026

Issue

Very rare app cannot find parent dir

Changes

Uses file id first if fails uses path
Covers edge cases
Adds tests

Demo

Screen_recording_20260414_154306.webm

@alperozturk96 alperozturk96 added this to the Nextcloud App 33.1.0 milestone Apr 14, 2026
@alperozturk96
Copy link
Copy Markdown
Collaborator Author

/backport to stable-33.1.0

@github-actions
Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/24402771557/artifacts/6429608895
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Copy link
Copy Markdown
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add unit test
maybe it can be reproduced via copy/move if previously folder was a/b/c, but now c does not exist anylonger.

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/file-list-on-browse-up branch from da3b83d to 2b2d4c1 Compare April 15, 2026 12:01
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions
Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/24453744277/artifacts/6450181043
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
Copy link
Copy Markdown
Collaborator Author

alperozturk96 commented Apr 15, 2026

browse up if parent deleted instead browse to root

Screen_recording_20260415_143047.webm

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions
Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness6969
Dodgy code226226
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total432432

@github-actions
Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/24454860564/artifacts/6450667081
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96 alperozturk96 merged commit 4e035ce into master Apr 15, 2026
14 of 19 checks passed
@alperozturk96 alperozturk96 deleted the fix/file-list-on-browse-up branch April 15, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants