Chore/improve clang tidy integration - #10666
Open
mgallien wants to merge 10 commits into
Open
Conversation
mgallien
requested review from
camilasan,
claucambra,
i2h3 and
nilsding
as code owners
August 25, 2026 11:43
mgallien
force-pushed
the
chore/improveClangTidyIntegration
branch
3 times, most recently
from
August 26, 2026 08:42
6e33e38 to
b843837
Compare
Extract the inline -checks= list from the CI workflow into a .clang-tidy configuration file so the check set is discoverable outside CI and can be reused by local/IDE runs of clang-tidy. Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
also enforce it via clang-tidy configuration file Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
also add it to our configuration file to be enforced Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Broaden the clang-format requirement beyond ./src to all C++ source files, and add a mandatory run-clang-tidy -fix pass that must report no further changes before a task is considered done. Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
The step should not fail the job on lint warnings; fixes.yml is still exported and consumed by the PR-comments step regardless of exit code. Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
added some exceptions Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
chore/improveClangTidyIntegration
branch
from
August 29, 2026 17:34
92b2f21 to
8751f13
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10666.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #include <QPushButton> | ||
| #include <QTimeZone> | ||
|
|
||
| #include "ui_sslerrordialog.h" |
Contributor
There was a problem hiding this comment.
❌ clang-diagnostic-error ❌
ui_sslerrordialog.h file not found
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
#
Summary
TODO
Checklist
AI (if applicable)