Repository navigation
feat: allow anonymous sessions for async status updates - #752
Merged
Merged
Conversation
The biggest usecase would be e.g. chunked uploading, we should be able to early close the connection (prevent e.g. WAF issues) and then still give the UI asynchronous status updates. Also needed for other long running processes where the request itself might get terminated due to timeouts (network issues, WAF, etc). Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
icewind1991
reviewed
Sep 16, 2026
| /// the user backend allows in user ids. | ||
| #[derive(Clone, Copy, Eq, PartialEq)] | ||
| enum IdKind { | ||
| User = 0, |
Member
There was a problem hiding this comment.
there is no need to assign values to the enum variants
icewind1991
approved these changes
Sep 16, 2026
Signed-off-by: Robin Appelman <robin@icewind.nl>
susnux
commented
Sep 16, 2026
susnux
left a comment
susnux
left a comment
Contributor
Author
There was a problem hiding this comment.
✅ thanks for the pushed fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The biggest usecase would be e.g. chunked uploading, we should be able to early close the connection (prevent e.g. WAF issues) and then still give the UI asynchronous status updates. Also needed for other long running processes where the request itself might get terminated due to timeouts (network issues, WAF, etc).
🤖 AI (if applicable)