Fix app name not translated in the title of public pages#59639
Open
Fix app name not translated in the title of public pages#59639
Conversation
@nextcloud/vue automatically adds the localized app name to the page title if a page heading but not an explicit page title is given. The localized app name is expected to be provided in the "core->apps" initial state, but that was set only when rendering a page as a registered user. In public pages that data was not provided, so the title contained the app ID rather than the localized app name. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Member
Author
|
/backport to stable33 please |
Member
Author
|
/backport to stable32 please |
Member
Author
|
Although it keeps failing after several restarts Cypress error should be unrelated. |
danxuliu
requested review from
Altahrim,
ArtificialOwl,
icewind1991 and
nfebe
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nextcloud/vue automatically adds the localized app name to the page title if a page heading but not an explicit page title is given. The localized app name is expected to be provided in the
core->appsinitial state, but that was set only when rendering a page as a registered user. In public pages that data was not provided, so the title contained the app ID rather than the localized app name.How to test
Result with this pull request
The title of the page is
Öffentliche Dateifreigabe - Dateien - NextcloudResult without this pull request
The title of the page is
Öffentliche Dateifreigabe - files - Nextcloud