[stable32] fix(files_external): ignore unsatisfied optional dependencies#59642
Open
leftybournes wants to merge 3 commits intostable32from
Open
[stable32] fix(files_external): ignore unsatisfied optional dependencies#59642leftybournes wants to merge 3 commits intostable32from
leftybournes wants to merge 3 commits intostable32from
Conversation
Signed-off-by: Jan-Philipp Litza <janphilipp@litza.de>
To check if there are no missing required dependencies we need to check if the required dependencies are **empty** because `!array` is still true. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Carl Schwan <carl@carlschwan.eu> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
leftybournes
requested review from
ArtificialOwl,
icewind1991,
nfebe and
sorbaugh
and removed request for
a team
CarlSchwan
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #54048 and #58589