refactor(dav): improve readability of Sabre File::put upload flow#60974
Draft
joshtrichards wants to merge 6 commits into
Draft
refactor(dav): improve readability of Sabre File::put upload flow#60974joshtrichards wants to merge 6 commits into
joshtrichards wants to merge 6 commits into
Conversation
Some low-risk quick wins: - clearer local variable names - section comments - extracted repeated lock-upgrade logic - extracted stream normalization - extracted hash wrapping - extracted expected-size parsing Signed-off-by: Josh <josh.t.richards@gmail.com>
…ut() - put() is shorter and more skimmable - write mechanics are isolated in writePutDataToStorage() - size validation is named explicitly - metadata/header handling is isolated in applyUploadMetadata() Signed-off-by: Josh <josh.t.richards@gmail.com>
… File::put() Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a fairly mechanical refactor of
OCA\DAV\Connector\Sabre\File::put()to improve readability and maintainability without intentionally changing behavior.Why
put()is really long and handles several responsibilities at once:This change keeps the existing flow but makes the method easier to follow by turning it into a higher-level orchestration method.
What changed
resolveUploadTarget()put()Notes
Testing
Checklist
3. to review, feature component)stable32)AI (if applicable)